Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.3] [Synthetics] adjust enabled key for browser monitors #135016

Merged

Conversation

dominiqueclarke
Copy link
Contributor

Summary

Adjusts the enabled key so it doesn't end up being overwitten.

Run

npx @elastic/synthetics push examples/todos/basic.journey.ts --auth [YOUR API KEY]  --url [YOUR KIBANA URL] --project test-project --schedule 10 --locations us_east

With a monitor disabled via

monitor.use({ enabled: false });

Then confirm in Kibana that the monitor displays as disabled.

@dominiqueclarke dominiqueclarke added bug Fixes for quality problems that affect the customer experience Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability release_note:skip Skip the PR/issue when compiling release notes v8.3.0 labels Jun 23, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@dominiqueclarke dominiqueclarke changed the title [Synthetics] adjust enabled key for browser monitors [8.3] [Synthetics] adjust enabled key for browser monitors Jun 23, 2022
Copy link
Contributor

@shahzad31 shahzad31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't override the UI value !!

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dominiqueclarke
Copy link
Contributor Author

Doesn't override the UI value !!

Please try on this branch, which has upstream. I believe when testing on the main branch it was missing the commit that fixed decryption. That has now been updated as well.

Copy link
Contributor

@shahzad31 shahzad31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's working after upstream merge updated !!

@dominiqueclarke dominiqueclarke merged commit 8a54c80 into elastic:8.3 Jun 23, 2022
@dominiqueclarke dominiqueclarke deleted the fix/synthetics-8-3-enabled branch June 23, 2022 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants