Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Investigations] - Fix resolver horizontal rule icon #134832

Merged
merged 1 commit into from
Jun 21, 2022
Merged

[Security Solution][Investigations] - Fix resolver horizontal rule icon #134832

merged 1 commit into from
Jun 21, 2022

Conversation

michaelolo24
Copy link
Contributor

Summary

Addresses #132216 by fixing the css for the horizontal rule

Screen Shot 2022-06-21 at 8 52 23 AM

@michaelolo24 michaelolo24 added bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed Team:Threat Hunting:Investigations Security Solution Investigations Team v8.3.0 v8.4.0 labels Jun 21, 2022
@michaelolo24 michaelolo24 requested a review from a team as a code owner June 21, 2022 13:06
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 5.3MB 5.3MB -261.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kqualters-elastic
kqualters-elastic approved these changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@kqualters-elastic kqualters-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm 👍 although at this point i think it might make sense to remove the horizontal rule entirely

@michaelolo24
Copy link
Contributor Author

code lgtm 👍 although at this point i think it might make sense to remove the horizontal rule entirely

Yea, we can remove all of that later on. Especially with any re-design/replacement of the panel

@michaelolo24 michaelolo24 merged commit 61be8fb into elastic:main Jun 21, 2022
kibanamachine pushed a commit that referenced this pull request Jun 21, 2022
@michaelolo24
fix horizontal rule (#134832)
48d1c66 
(cherry picked from commit 61be8fb)
@kibanamachine kibanamachine mentioned this pull request Jun 21, 2022
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.3

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jun 21, 2022
@kibanamachine @michaelolo24
fix horizontal rule (#134832) (#134845)
e6ecddc 
(cherry picked from commit 61be8fb)

Co-authored-by: Michael Olorunnisola <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kqualters-elastic kqualters-elastic kqualters-elastic approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Investigations Security Solution Investigations Team v8.3.0 v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@michaelolo24 @kibana-ci @kibanamachine @kqualters-elastic