Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graph a11y tests #134694

Merged
merged 11 commits into from
Jun 20, 2022
Merged

Graph a11y tests #134694

merged 11 commits into from
Jun 20, 2022

Conversation

bhavyarm
Copy link
Contributor

Meta - #51456

A11y tests for graph

@bhavyarm bhavyarm requested a review from a team as a code owner June 17, 2022 18:19
@bhavyarm bhavyarm self-assigned this Jun 17, 2022
@bhavyarm bhavyarm added v8.4.0 Feature:Graph Graph application feature labels Jun 17, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-graph (Feature:Graph)

@bhavyarm bhavyarm added the Team:QA Team label for QA Team label Jun 17, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-qa (Team:QA)

@bhavyarm bhavyarm added release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v8.3.1 labels Jun 17, 2022
@bhavyarm bhavyarm mentioned this pull request Jun 17, 2022
Closed
jughosta
jughosta approved these changes Jun 20, 2022
View reviewed changes
Copy link
Contributor

@jughosta jughosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one question. Besides that LGTM, thanks! 👍

x-pack/test/accessibility/config.ts Outdated Show resolved Hide resolved
@bhavyarm bhavyarm requested a review from rashmivkulkarni June 20, 2022 16:39
@rashmivkulkarni
Copy link
Contributor

@bhavyarm - has this PR been through flaky test runner ?

rashmivkulkarni
rashmivkulkarni approved these changes Jun 20, 2022
View reviewed changes
Copy link
Contributor

@rashmivkulkarni rashmivkulkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM , code review.
Please merge once Flaky test runner is green on this PR.

@bhavyarm
Copy link
Contributor Author

@rashmivkulkarni thanks. That is the plan :) https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/763

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
graph 475.0KB 475.1KB +102.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @bhavyarm

@bhavyarm bhavyarm merged commit 7e44314 into elastic:main Jun 20, 2022
@bhavyarm bhavyarm removed the v8.3.1 label Jun 20, 2022
kibanamachine pushed a commit that referenced this pull request Jun 20, 2022
@bhavyarm
Graph a11y tests (#134694)
781f911 
Graph a11y tests

(cherry picked from commit 7e44314)
@kibanamachine kibanamachine mentioned this pull request Jun 20, 2022
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.3

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jun 20, 2022
@kibanamachine @bhavyarm
Graph a11y tests (#134694) (#134777)
472d3f1 
Graph a11y tests

(cherry picked from commit 7e44314)

Co-authored-by: Bhavya RM <[email protected]>
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-accessibility (Project:Accessibility)

@bhavyarm bhavyarm mentioned this pull request Jun 21, 2022
Open
77 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jughosta jughosta jughosta approved these changes

@rashmivkulkarni rashmivkulkarni rashmivkulkarni approved these changes

Assignees

@bhavyarm bhavyarm

Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Graph Graph application feature Project:Accessibility release_note:skip Skip the PR/issue when compiling release notes Team:QA Team label for QA Team v8.3.0 v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bhavyarm @elasticmachine @rashmivkulkarni @kibana-ci @kibanamachine @jughosta