Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Add data view changed warning after alert rule created #134674

Merged
merged 16 commits into from
Jul 4, 2022
Merged

[Discover] Add data view changed warning after alert rule created #134674

merged 16 commits into from
Jul 4, 2022

Conversation

dimaanj
Copy link
Contributor

@dimaanj dimaanj commented Jun 17, 2022

Summary

Closes #134232

This PR adds extra waring in case the user updated data view after alert rule creation/updating.

Test

  • Create an alert off a query that uses a certain field
  • Add field as a field filter in a Data View
  • Follow the link to see results triggered the alert.
  • Filtered field will not be shown. Instead user should see additional warning.

455C6C75-7467-41EE-8012-ACA8AF03546B_4_5005_c

Checklist

Delete any items that are not applicable to this PR.

@dimaanj dimaanj added release_note:enhancement Feature:Discover Discover Application Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.4.0 labels Jun 17, 2022
@dimaanj dimaanj self-assigned this Jun 17, 2022
@dimaanj dimaanj marked this pull request as ready for review June 21, 2022 10:35
@dimaanj dimaanj requested review from a team as code owners June 21, 2022 10:35
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@dimaanj
Copy link
Contributor Author

dimaanj commented Jun 21, 2022

@elasticmachine merge upstream

@kertal
Copy link
Member

kertal commented Jun 23, 2022

@elasticmachine merge upstream

@kertal
Copy link
Member

kertal commented Jun 23, 2022

@elasticmachine merge upstream

@MadameSheema MadameSheema mentioned this pull request Jun 23, 2022
Closed
@kertal
Copy link
Member

kertal commented Jun 24, 2022

@elasticmachine merge upstream

@kertal
Copy link
Member

kertal commented Jun 24, 2022

@elasticmachine merge upstream

@kertal
Copy link
Member

kertal commented Jun 27, 2022

@elasticmachine merge upstream

@dimaanj
Copy link
Contributor Author

dimaanj commented Jun 27, 2022

@elasticmachine merge upstream

@kertal
Copy link
Member

kertal commented Jun 28, 2022

@elasticmachine merge upstream

@kertal
Copy link
Member

kertal commented Jun 28, 2022

seems I can't use the cloud deployment to , can't get credentials ... checking...

@kertal
Copy link
Member

kertal commented Jun 28, 2022

@elasticmachine merge upstream - retriggering the cloud build, the recent seemed to be broken, could create data views, but it was not possible to go to Discover, I was told, there are no data view ... let's see if a new instance works

@dimaanj
Copy link
Contributor Author

dimaanj commented Jun 28, 2022

elasticmachine merge upstream

@kertal
Copy link
Member

kertal commented Jun 28, 2022

elasticmachine merge upstream - now it should work, there was a bug preventing saving data views

@kertal
Copy link
Member

kertal commented Jun 29, 2022

elasticmachine merge upstream

@kertal
Copy link
Member

kertal commented Jun 29, 2022

@elasticmachine merge upstream - @dimaanj that's why copy paste is bad sometimes, I was wondering why no build was triggered ... we both wrote elasticmachine merge upstream

kertal
kertal approved these changes Jun 29, 2022
View reviewed changes
Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Finally there was not deployment error, demo data installation failure, no data view notification page that refused to go away. All unrelated to this PR. Tested in cloud and works as expected

tsullivan
tsullivan approved these changes Jun 29, 2022
View reviewed changes
Copy link
Member

@tsullivan tsullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

data-test-subj changes LGTM

@kertal
Copy link
Member

kertal commented Jul 4, 2022

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dataViewManagement 180.8KB 180.9KB +76.0B
discover 491.2KB 491.7KB +573.0B
total +649.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dimaanj

@dimaanj dimaanj merged commit 8e607cc into elastic:main Jul 4, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jul 4, 2022
yakhinvadim pushed a commit to yakhinvadim/kibana that referenced this pull request Jul 5, 2022
@dimaanj
[Discover] Add data view changed warning after alert rule created (el…
8bbd0c8 
…astic#134674)

* [Discover] add data view changed warn

* [Discover] add functional test

* [Discover] update snapshot

* [Discover] adjust comment

* [Discover] apply suggestions
@tylersmalley tylersmalley added ci:cloud-deploy Create or update a Cloud deployment and removed ci:deploy-cloud labels Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsullivan tsullivan tsullivan approved these changes

@kertal kertal kertal approved these changes

Assignees

@dimaanj dimaanj

Labels
backport:skip This commit does not require backporting ci:cloud-deploy Create or update a Cloud deployment Feature:Discover Discover Application release_note:enhancement Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Discover][Alerting] Add info when data view has changed after rule creation
7 participants
@dimaanj @elasticmachine @kertal @kibana-ci @tsullivan @tylersmalley @kibanamachine