[Discover] Hide "Add a field", "Edit" and "Create a data view" buttons in viewer mode #134582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d only access on mobile
…ere reduced for a user in meantime
jughosta
added
Feature:Discover
jughosta
commented
Jun 17, 2022
| ); | ||
|
|
||
| const createNewDataView = useCallback(() => { | ||
| const dataViewEditPermission = dataViewEditor.userPermissions.editDataView; |
There was a problem hiding this comment.
It's a function which returns a boolean .editDataView()
jughosta
changed the title
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
|
@elasticmachine merge upstream |
jloleysens
approved these changes
Jun 20, 2022
dej611
approved these changes
Jun 20, 2022
| @@ -244,7 +244,7 @@ export const LensTopNavMenu = ({ | |||
| const [indexPatterns, setIndexPatterns] = useState<DataView[]>([]); | |||
| const [currentIndexPattern, setCurrentIndexPattern] = useState<DataView>(); | |||
| const [rejectedIndexPatterns, setRejectedIndexPatterns] = useState<string[]>([]); | |||
| const editPermission = dataViewFieldEditor.userPermissions.editIndexPattern(); | |||
| const canEditDataView = !!dataViewEditor?.userPermissions.editDataView(); | |||
There was a problem hiding this comment.
nit: in Lens we usually use the convention Boolean( ... ) rather than !! ...
kertal
reviewed
Jun 20, 2022
Comment on lines
+71
to
+76
| /** | ||
| * Handles "Edit field" action | ||
| * Buttons will be hidden if not provided | ||
| * @param fieldName | ||
| */ | ||
| editField?: (fieldName?: string) => void; |
There was a problem hiding this comment.
👍 for the solution and the documentation
kertal
approved these changes
Jun 20, 2022
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @jughosta |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 21, 2022
…s in viewer mode (elastic#134582) * [Discover] Hide "Add a field" button for read only access * [Discover] Hide "Create a data view" button for read only access on desktop * [Discover] Hide "Create a data view" and "Add a field" button for read only access on mobile * [Discover] Make sure that error message is shown when access rights were reduced for a user in meantime * [Discover] Make checks safe * [Discover] Update tests * [Discover] Streamline the logic * [Discover] Update tests * [Discover] Add tests * [Discover] Add tests * [Discover] Update code style Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit 7410fbf)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jun 21, 2022
…s in viewer mode (#134582) (#134802) * [Discover] Hide "Add a field" button for read only access * [Discover] Hide "Create a data view" button for read only access on desktop * [Discover] Hide "Create a data view" and "Add a field" button for read only access on mobile * [Discover] Make sure that error message is shown when access rights were reduced for a user in meantime * [Discover] Make checks safe * [Discover] Update tests * [Discover] Streamline the logic * [Discover] Update tests * [Discover] Add tests * [Discover] Add tests * [Discover] Update code style Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit 7410fbf) Co-authored-by: Julia Rechkunova <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #134265
Summary
This PR hides the bottom "Add a field" button from Discover sidebar and "Create a data view" button from Unified search data view picker for desktop and mobile views if user does not have rights to edit data views.
If user opens a flyout to create a field or data view and somebody reduces that user access rights in the meantime, on Save action an error toast will be shown to the user instead of no feedback.
Checklist