[Shared UX] Move Solution Toolbar components to package

[clintandrewhall]

Summary

As titled, moving another set of components to a package.

Open Questions

• @cchaos Any feedback on the package name? We still haven't created the actual SolutionToolbar yet.
• @thompsongl IconButtonGroup is using an emotion technique I'm not familiar with, and it's also not working, (the styles are being overloaded by specificity). Can you assist with a technique to be more current that also works?

[thompsongl]

the styles are being overloaded by specificity

As in the IconButtonGroup styles applied by Emotion are overridden by those from Sass/compiled CSS?

[cchaos]

Any feedback on the package name? We still haven't created the actual SolutionToolbar yet.

I would be descriptive about what it is: ButtonToolbar since it just groups buttons together but then not to be confused with buttonGroup

[cchaos]

Found a few lingering mentions of "Solution"

[clintandrewhall]

@thompsongl You can see the issue here: https://ci-artifacts.kibana.dev/storybooks/pr-134392/f0093ba142591a6e8320a9daba00e05a5f3fa28c/shared_ux/index.html?path=/story/solution-toolbar-buttons--icon-button-group

The styles are overridden by the base EUI styles. Curious how to adapt the Emotion styles to overcome that specificity. And this used to work, AFAIK.

[thompsongl]

Spoke to @clintandrewhall about the specificity problem and it's a known effect. The EUI team has a fix in the works that will enable Kibana to better order styles coming from Emotion: elastic/eui#5853

This will be available and enabled in Kibana by 8.4 FF. You'll need to do no extra work.

If you want to increase specificity in the meantime, you can chain the selector in question:
'&.euiButtonGroupButton' to '&.euiButtonGroupButton.euiButtonGroupButton' or '&.euiButtonGroupButton.euiButtonGroupButton.euiButtonGroupButton'

[clintandrewhall]

Thanks @thompsongl ... we'll just leave as-is, for now, and let your fix take care of it.

[cchaos]

we'll just leave as-is

Are the any actual usages of this right now? I would be concerned about this visual regression even if temporary. But if it's not consumed just yet, then we're ok.

[clintandrewhall]

@cchaos yeah, it's not used anywhere yet

[ThomThomson]

Presentation team changes LGTM, just changes to deprecation comments.

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: c31fb4e
• Storybooks Preview
• Webpack Bundle Analyzer

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
dashboard	425	419	-6
discover	594	588	-6
home	147	141	-6
kibanaOverview	179	173	-6
lens	926	920	-6
observability	497	491	-6
securitySolution	3078	3072	-6
visualizations	377	371	-6
total			-48

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
@kbn/shared-ux-button-toolbar	-	6	+6
@kbn/shared-ux-components	15	7	-8
total			-2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
dashboard	391.4KB	391.4KB	-1.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
@kbn/shared-ux-components	3	2	-1

Unknown metric groups

API count

id	before	after	diff
@kbn/shared-ux-button-toolbar	-	20	+20
@kbn/shared-ux-components	21	13	-8
total			+12

History

• 💚 Build #51384 succeeded 1349871
• 💚 Build #51262 succeeded 48c4323
• 💚 Build #51092 succeeded 78cdf7e
• 💚 Build #50927 succeeded f0093ba
• 💔 Build #50925 failed 765ebe7
• 💔 Build #50906 failed 39b082a

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[majagrubic]

Tested in storybook in Chrome on Mac OSX, works as expected. Had only a brief look at the code, since it's mostly moving files around, I wasn't expecting any major changes.