-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle booleans in filter editor #13406
Conversation
FWIW, I think the UI will be a little easier to parse if you use a |
@cjcenizal I agree. I've updated it to use a select instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was able to reproduce the "empty bool value" effect that @Bargs reported by performing these steps in the same tab without reloading:
For me, all the values in that column as well as the filter descriptions were empty. There seems to be something wrong with the boolean field formatters, so it is probably not related to this PR. A page reload fixes it. |
* Handle booleans in filter editor * Use select instead of checkbox
* Handle booleans in filter editor * Use select instead of checkbox
* Handle booleans in filter editor * Use select instead of checkbox
Fixes #12745.
This PR updates the filter editor to properly handle fields of type boolean. It also removes the "is one of" and "is not one of" options from the boolean field type (because they don't make much sense).