-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make filter pills keyboard accessible #13331
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The actual focusing works fine. I just noticed, that we don't have any issue yet, that none of that buttons has any text/label/name, meaning you can now focus them, but a visual impaired user would still not be able to use them at all.
Should we fix that issue directly with this PR and add aria-label
s to all of them?
Great point @timroes, we might as well add those in this PR. Is |
jenkins, test this |
1 similar comment
jenkins, test this |
I think to make the meaning more clear to seeing users, our current approach would be to add a hover tooltip to it (same as e.g. in the collapsed main navigation). You could give each of that tooltips a unique |
That sounds awesome, but maybe a bit more than I want to bite off in this PR 😅 I'll just add the aria-labels for now, and create a new issue for the tooltip enhancement. |
@timroes I added the aria-labels |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes elastic#12639 It's now possible to tab to each filter's actions and interact with them via the keyboard. In order to get the actions to show/hide on both mouse hover and action focus I had to create a new filter-pill component that could manage a bit of state to track whether the user was interacting with a given pill or not.
Fixes elastic#12639 It's now possible to tab to each filter's actions and interact with them via the keyboard. In order to get the actions to show/hide on both mouse hover and action focus I had to create a new filter-pill component that could manage a bit of state to track whether the user was interacting with a given pill or not.
Fixes #12639 It's now possible to tab to each filter's actions and interact with them via the keyboard. In order to get the actions to show/hide on both mouse hover and action focus I had to create a new filter-pill component that could manage a bit of state to track whether the user was interacting with a given pill or not.
Fixes #12639 It's now possible to tab to each filter's actions and interact with them via the keyboard. In order to get the actions to show/hide on both mouse hover and action focus I had to create a new filter-pill component that could manage a bit of state to track whether the user was interacting with a given pill or not.
Fixes #12639
It's now possible to tab to each filter's actions and interact with them via the keyboard.
In order to get the actions to show/hide on both mouse hover and action focus I had to create a new
filter-pill
component that could manage a bit of state to track whether the user was interacting with a given pill or not.