Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unskip flaky test in Alerting API Integration #133278

Merged
merged 1 commit into from
Jun 2, 2022

Conversation

jughosta
Copy link
Contributor

@jughosta jughosta commented Jun 1, 2022

Closes #129380

Summary

This PR increases interval for generating data.
An issue with parsing dates seems to be related to elastic/elasticsearch#50265

Flaky test runner 100x https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/700
Another 100x test https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/705

Checklist

@jughosta jughosta added release_note:fix backport:skip This commit does not require backporting Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.4.0 labels Jun 1, 2022
@jughosta jughosta self-assigned this Jun 1, 2022
@jughosta jughosta changed the title Fix flaky test in Alerting API Integration Unskip flaky test in Alerting API Integration Jun 1, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jughosta

@jughosta jughosta added v8.3.0 auto-backport Deprecated - use backport:version if exact versions are needed and removed backport:skip This commit does not require backporting labels Jun 1, 2022
@jughosta jughosta marked this pull request as ready for review June 1, 2022 11:23
@jughosta jughosta requested a review from a team as a code owner June 1, 2022 11:23
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx for taking care of it! 🙏

@ymao1
Copy link
Contributor

ymao1 commented Jun 1, 2022

@jughosta I see that the test is no longer flaky, which is great! Just wondering why having a smaller interval would lead to the error being thrown during search?

@jughosta
Copy link
Contributor Author

jughosta commented Jun 2, 2022

Hi @ymao1 !
I don't have enough context to answer why with smaller intervals ES fails to parse dates. This PR gave an idea to try with a larger interval. Comments from there also have links to other issues.

Copy link
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jughosta jughosta merged commit c337393 into elastic:main Jun 2, 2022
@jughosta jughosta deleted the 129380-flaky-test-alert branch June 2, 2022 12:21
kibanamachine pushed a commit that referenced this pull request Jun 2, 2022
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.3

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jun 2, 2022
…ents (#133278) (#133389)

(cherry picked from commit c337393)

Co-authored-by: Julia Rechkunova <[email protected]>
@kertal kertal added release_note:skip Skip the PR/issue when compiling release notes and removed release_note:fix labels Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.3.0 v8.4.0
Projects
None yet
6 participants