Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve region map documentation #13319

Merged

Conversation

thomasneirynck
Copy link
Contributor

No description provided.

@thomasneirynck thomasneirynck added Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Team:Docs review v5.5.2 v5.6.0 v6.0.0 v7.0.0 labels Aug 3, 2017
Copy link

@alexfrancoeur alexfrancoeur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -54,6 +54,7 @@ when necessary.
`visualization:colorMapping`:: Maps values to specified colors within visualizations.
`visualization:loadingDelay`:: Time to wait before dimming visualizations during query.
`visualization:dimmingOpacity`:: When part of a visualization is highlighted, by hovering over it for example, ths is the opacity applied to the other elements. A higher number means other elements will be less opaque.
`visualization:regionmap:showWarnings`:: Whether the region map show a warning when terms cannot be joined to a shape on the map.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great addition to the docs!

- *Join field*: this is the property from the selected vector map that will be used to join on the terms in your terms-aggregation.
- *Join field*: this is the property from the selected vector map that will be used to join on the terms in your terms-aggregation.
When terms cannot be joined to any of the shapes in the vector layer because there is no exact match in the vector layer, Kibana will display a warning.
To turn of these warnings, go to *Management/Kibana/Advanced Settings* and set `visualization:regionmap:showWarnings` to `vefalse`.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+++++

@@ -26,10 +26,12 @@ Configure a _Terms_ aggregation. The term is the _key_ that is used to join the
==== Options

===== Layer Settings
- *Vector map*: select from a list of vector maps. This list includes the maps that are hosted by the © [Elastic Maps Service](https://www.elastic.co/elastic-maps-service),
- *Vector map*: select from a list of vector maps. This list includes the maps that are hosted by the © https://www.elastic.co/elastic-maps-service[Elastic Maps Service],

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm having issues building locally but if I recall this is the correct way to format URL's in asciidoc 😄

Copy link
Contributor Author

@thomasneirynck thomasneirynck Aug 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you wouldn't think so, but yes ;)

@thomasneirynck thomasneirynck merged commit 5fe682d into elastic:master Aug 3, 2017
thomasneirynck added a commit that referenced this pull request Aug 3, 2017
thomasneirynck added a commit that referenced this pull request Aug 3, 2017
thomasneirynck added a commit that referenced this pull request Aug 3, 2017
thomasneirynck added a commit that referenced this pull request Aug 3, 2017
@thomasneirynck
Copy link
Contributor Author

Backports:
6.x: 1998616
6.0: 66a592b
5.6: e5ad25c
5.5: 60c9dd9

@thomasneirynck
Copy link
Contributor Author

fixed the typo after merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Visualizations Generic visualization features (in case no more specific feature label is available) review Team:Docs v5.5.2 v5.6.0 v6.0.0 v7.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants