-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UI Framework][K7]: Side nav component #13304
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
7bc0c48
set side nav
snide 611f311
side nav component, add depth
snide 869bc37
fix font usage
snide 39077c4
star messing with responsive layouts
snide 0190cbe
open close state for sidenav in mobile
snide e34307c
clean up code, set up proper state
snide 1d9a03e
add some better docs
snide 80d6b7c
use kuiSizeM instead of math
snide 004d3ca
best solution for responsive system
snide 4e5f125
don't let guide set bg color
snide 66ffaba
css compile after rebase
snide 9a978cd
address CJ feedback
snide File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
import React from 'react'; | ||
|
||
import { | ||
KuiSideNav, | ||
KuiSideNavItem, | ||
KuiSideNavTitle, | ||
} from '../../../../components'; | ||
|
||
export default () => ( | ||
<KuiSideNav> | ||
<KuiSideNavTitle>Elasticsearch</KuiSideNavTitle> | ||
<KuiSideNavItem>Data sources</KuiSideNavItem> | ||
<KuiSideNavItem>Users</KuiSideNavItem> | ||
<KuiSideNavItem>Roles</KuiSideNavItem> | ||
<KuiSideNavItem isSelected>Watches</KuiSideNavItem> | ||
<KuiSideNavItem>Extremely long item is long</KuiSideNavItem> | ||
|
||
<KuiSideNavTitle>Kibana</KuiSideNavTitle> | ||
<KuiSideNavItem>Index Patterns</KuiSideNavItem> | ||
<KuiSideNavItem>Saved Objects</KuiSideNavItem> | ||
<KuiSideNavItem>Reporting</KuiSideNavItem> | ||
|
||
<KuiSideNavTitle>Logstash</KuiSideNavTitle> | ||
<KuiSideNavItem>Pipeline Viewer</KuiSideNavItem> | ||
</KuiSideNav> | ||
); |
39 changes: 39 additions & 0 deletions
39
ui_framework/doc_site/src/views/side_nav/side_nav_example.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
import React from 'react'; | ||
|
||
import { renderToHtml } from '../../services'; | ||
|
||
import { | ||
GuideDemo, | ||
GuidePage, | ||
GuideSection, | ||
GuideSectionTypes, | ||
GuideText, | ||
} from '../../components'; | ||
|
||
import SideNav from './side_nav'; | ||
const sideNavSource = require('!!raw!./side_nav'); | ||
const sideNavHtml = renderToHtml(SideNav); | ||
|
||
export default props => ( | ||
<GuidePage title={props.route.name}> | ||
<GuideSection | ||
title="SideNav" | ||
source={[{ | ||
type: GuideSectionTypes.JS, | ||
code: sideNavSource, | ||
}, { | ||
type: GuideSectionTypes.HTML, | ||
code: sideNavHtml, | ||
}]} | ||
> | ||
<GuideText> | ||
The sidenav is a responsive menu system that usually sits on the left side of a page layout. | ||
It will exapand to the width of its container. | ||
</GuideText> | ||
|
||
<GuideDemo> | ||
<SideNav /> | ||
</GuideDemo> | ||
</GuideSection> | ||
</GuidePage> | ||
); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make this example much longer, so we can see how content wraps? Maybe it should truncate with an ellipsis instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does trunctate! That's what this shows. :)