Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SecuritySolution] Hide the "Investigate in TL" button for the agent status field #132829

Merged
merged 3 commits into from
May 25, 2022
Merged

[SecuritySolution] Hide the "Investigate in TL" button for the agent status field #132829

merged 3 commits into from
May 25, 2022

Conversation

janmonschke
Copy link
Contributor

Summary

This PR disables the Investigate in timeline action for the agent status field. That field is not searchable and therefore an investigation will not return any alerts. This issue was originally described in #132095.

Screen.Recording.2022-05-24.at.18.29.41.mov

Checklist

@janmonschke janmonschke added release_note:fix backport:skip This commit does not require backporting Team:Threat Hunting:Investigations Security Solution Investigations Team v8.3.0 labels May 24, 2022
@janmonschke janmonschke self-assigned this May 24, 2022
@janmonschke janmonschke requested a review from a team as a code owner May 24, 2022 16:34
andrew-goldstein
andrew-goldstein approved these changes May 24, 2022
View reviewed changes
Copy link
Contributor

@andrew-goldstein andrew-goldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @janmonschke! 🙏

✅ desk tested locally

LGTM

YulNaumenko
YulNaumenko approved these changes May 25, 2022
View reviewed changes
Copy link
Contributor

@YulNaumenko YulNaumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@janmonschke janmonschke enabled auto-merge (squash) May 25, 2022 07:07
@janmonschke
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 5.0MB 5.0MB +115.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @janmonschke

@janmonschke janmonschke merged commit 469094c into elastic:main May 25, 2022
@janmonschke janmonschke mentioned this pull request Jun 2, 2022
Merged
janmonschke added a commit to janmonschke/kibana that referenced this pull request Jun 2, 2022
@janmonschke
[SecuritySolution] Hide the "Investigate in TL" button for the agent …
85e6dc7 
…status field (elastic#132829)

* fix: don't show the "Investigate in TL" button for the agent status field

elastic#132095

* copy: typo 🐏

(cherry picked from commit 469094c)
janmonschke added a commit that referenced this pull request Jun 2, 2022
@janmonschke
[SecuritySolution] Hide the "Investigate in TL" button for the agent …
8aed3bb 
…status field (#132829) (#133395)

* fix: don't show the "Investigate in TL" button for the agent status field

#132095

* copy: typo 🐏

(cherry picked from commit 469094c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YulNaumenko YulNaumenko YulNaumenko approved these changes

@andrew-goldstein andrew-goldstein andrew-goldstein approved these changes

Assignees

@janmonschke janmonschke

Labels
backport:skip This commit does not require backporting release_note:fix Team:Threat Hunting:Investigations Security Solution Investigations Team v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@janmonschke @kibana-ci @andrew-goldstein @YulNaumenko @kibanamachine