Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Fix flaky test for "allows editing of a newly created field" #132812

Merged
merged 4 commits into from
May 25, 2022
Merged

[Discover] Fix flaky test for "allows editing of a newly created field" #132812

merged 4 commits into from
May 25, 2022

Conversation

jughosta
Copy link
Contributor

@jughosta jughosta commented May 24, 2022 •
edited
Loading

Closes #123372

Flaky test runner 50x https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/664

Checklist

@jughosta jughosta added Feature:Discover Discover Application release_note:fix backport:skip This commit does not require backporting Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.4.0 labels May 24, 2022
@jughosta jughosta self-assigned this May 24, 2022
@jughosta jughosta marked this pull request as ready for review May 24, 2022 15:38
@jughosta jughosta requested a review from a team as a code owner May 24, 2022 15:38
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@jughosta
Copy link
Contributor Author

@elasticmachine merge upstream

@jughosta
Copy link
Contributor Author

@elasticmachine merge upstream

@jughosta
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jughosta

kertal
kertal reviewed May 25, 2022
View reviewed changes
test/functional/apps/discover/_runtime_fields_editor.ts
@@ -79,6 +78,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await fieldEditor.save();
await fieldEditor.confirmSave();
await PageObjects.header.waitUntilLoadingHasFinished();
await PageObjects.discover.waitForDocTableLoadingComplete();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flaky ones are sometimes a mystery, I wonder why this resolved the issue, I would have expected the retry on L83 to prevent flakiness. Just to be sure, it wouldn't fail on the 51the try, I started a 100 runs flaky test. LGTM https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/666

kertal
kertal approved these changes May 25, 2022
View reviewed changes
Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, thx a lot for taking care of this 👍

@jughosta jughosta merged commit 419f210 into elastic:main May 25, 2022
@jughosta jughosta deleted the 123372-flaky-test-runtime-fields branch May 25, 2022 07:58
@kertal
Copy link
Member

kertal commented May 25, 2022

oh, btw there's currently no 8.3 branch, so the tag should be changed, and even if there would be a 8.3 branch, since it failed in this version, it should be backported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kertal kertal kertal approved these changes

Assignees

@jughosta jughosta

Labels
backport:skip This commit does not require backporting Feature:Discover Discover Application release_note:fix Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.4.0
Projects
None yet
Milestone
No milestone
5 participants
@jughosta @elasticmachine @kibana-ci @kertal @kibanamachine