Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cloud Posture] Findings - set small size for last column in all tables #132793

Merged
merged 1 commit into from
May 24, 2022

Conversation

ari-aviran
Copy link
Contributor

@ari-aviran ari-aviran commented May 24, 2022

Summary

Cap the size of the last table column in all findings tables - Last checked in the findings and per-resource findings table, and Failed findings in the grouped-by-resource table.

Screenshots

Findings table - small screen

Before:

Screen Shot 2022-05-24 at 14 12 35

After:

Screen Shot 2022-05-24 at 14 14 51

Grouped-by-resource-id table - small screen

Before:

Screen Shot 2022-05-24 at 14 12 46

After:

Screen Shot 2022-05-24 at 14 15 02

Findings table - large screen

Before:

Screen Shot 2022-05-24 at 14 15 02

After:

Screen Shot 2022-05-24 at 14 15 02

Grouped-by-resource-id table - large screen

Before:

Screen Shot 2022-05-24 at 14 15 02

After:

Screen Shot 2022-05-24 at 14 15 02

@ari-aviran ari-aviran added release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Security Cloud Security team related v8.3.0 labels May 24, 2022
@ari-aviran ari-aviran requested a review from JordanSh May 24, 2022 11:24
@ari-aviran ari-aviran requested a review from a team as a code owner May 24, 2022 11:24
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security Posture)

@ari-aviran ari-aviran enabled auto-merge (squash) May 24, 2022 11:30
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #25 / Actions and Triggers app rules list should filter alerts by the status

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cloudSecurityPosture 182.5KB 182.5KB +46.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ari-aviran ari-aviran merged commit c3ea1b4 into elastic:main May 24, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label May 24, 2022
@ari-aviran ari-aviran deleted the findings_table_alignment branch May 24, 2022 12:30
@kfirpeled kfirpeled added v8.4.0 auto-backport Deprecated - use backport:version if exact versions are needed and removed backport:skip This commit does not require backporting labels May 26, 2022
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.4 The branch "8.4" is invalid or doesn't exist

Manual backport

To create the backport manually run:

node scripts/backport --pr 132793

Questions ?

Please refer to the Backport tool documentation

@ari-aviran
Copy link
Contributor Author

Exists in 8.3 c3ea1b4

@kfirpeled kfirpeled removed the v8.4.0 label May 26, 2022
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label May 27, 2022
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 132793 or prevent reminders by adding the backport:skip label.

@ari-aviran ari-aviran added backport:skip This commit does not require backporting and removed backport missing Added to PRs automatically when the are determined to be missing a backport. auto-backport Deprecated - use backport:version if exact versions are needed labels May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Security Cloud Security team related v8.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants