Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NA): include status on syncthetics_store.mock.ts #132764

Merged
merged 2 commits into from
May 24, 2022
Merged

fix(NA): include status on syncthetics_store.mock.ts #132764

merged 2 commits into from
May 24, 2022

Conversation

mistic
Copy link
Member

@mistic mistic commented May 24, 2022

This PR fixes a problem introduced at #132063 that is currently making our CI to fail

@mistic mistic requested a review from a team as a code owner May 24, 2022 03:00
@mistic mistic added chore Team:Operations Team label for Operations Team release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v8.3.0 labels May 24, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@mistic mistic mentioned this pull request May 24, 2022
Merged
9 tasks
@mistic mistic enabled auto-merge (squash) May 24, 2022 03:01
dominiqueclarke
dominiqueclarke approved these changes May 24, 2022
View reviewed changes
Copy link
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mistic mistic merged commit 35a4274 into elastic:main May 24, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled in files

id before after diff
apm 14 15 +1
synthetics 6 7 +1
total +2

ESLint disabled line counts

id before after diff
apm 81 84 +3
synthetics 56 62 +6
total +9

Total ESLint disabled count

id before after diff
apm 95 99 +4
synthetics 62 69 +7
total +11

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominiqueclarke dominiqueclarke dominiqueclarke approved these changes

@lucasfcosta lucasfcosta Awaiting requested review from lucasfcosta

@shazadahmed996 shazadahmed996 Awaiting requested review from shazadahmed996

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting chore release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mistic @elasticmachine @kibana-ci @dominiqueclarke