Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UX Dashboard] Remove search url query from APM server #132654

Merged
merged 8 commits into from
May 31, 2022
Merged

[UX Dashboard] Remove search url query from APM server #132654

merged 8 commits into from
May 31, 2022

Conversation

justinkambic
Copy link
Contributor

Summary

Note to reviewers: This PR depends on #132548 and you shouldn't review it until that PR is merged.

Related to elastic/uptime#454.

  • migrated query from APM server to UX
  • deleted APM route and query generator function
  • may still need to update/remove some functional tests

@justinkambic justinkambic added chore technical debt Improvement of the software architecture and operational architecture Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability release_note:skip Skip the PR/issue when compiling release notes v8.3.0 v8.4.0 labels May 20, 2022
@justinkambic justinkambic self-assigned this May 20, 2022
@justinkambic justinkambic mentioned this pull request May 20, 2022
Closed
19 tasks
@justinkambic
Copy link
Contributor Author

@elasticmachine merge upstream

@justinkambic justinkambic marked this pull request as ready for review May 25, 2022 19:40
@justinkambic justinkambic requested review from a team as code owners May 25, 2022 19:40
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label May 25, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

sorenlouv
sorenlouv approved these changes May 25, 2022
View reviewed changes
Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

shahzad31
shahzad31 approved these changes May 26, 2022
View reviewed changes
Copy link
Contributor

@shahzad31 shahzad31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

@justinkambic
Copy link
Contributor Author

@elasticmachine merge upstream

@justinkambic
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
ux 138 140 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ux 155.3KB 156.1KB +816.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
ux 12 11 -1

Total ESLint disabled count

id before after diff
ux 13 12 -1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @justinkambic

@justinkambic justinkambic merged commit a15e5dd into elastic:main May 31, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label May 31, 2022
@justinkambic justinkambic deleted the 454/filter-search-input branch May 31, 2022 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorenlouv sorenlouv sorenlouv approved these changes

@shahzad31 shahzad31 shahzad31 approved these changes

Assignees

@justinkambic justinkambic

Labels
backport:skip This commit does not require backporting chore release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability technical debt Improvement of the software architecture and operational architecture v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@justinkambic @elasticmachine @kibana-ci @sorenlouv @shahzad31 @kibanamachine