Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds small styling updates to header panels #132596

Merged
merged 1 commit into from
May 20, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 12 additions & 20 deletions x-pack/plugins/observability/public/pages/rule_details/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -301,15 +301,15 @@ export function RuleDetailsPage() {
: [],
}}
>
<EuiFlexGroup wrap={true}>
<EuiFlexGroup wrap={true} gutterSize="m">
{/* Left side of Rule Summary */}
<EuiFlexItem grow={1}>
<EuiPanel
color={getHealthColor(rule.executionStatus.status)}
hasBorder={false}
paddingSize={'l'}
paddingSize={'m'}
>
<EuiFlexGroup direction="column">
<EuiFlexGroup direction="column" gutterSize="xs">
<EuiFlexItem>
<EuiTitle size="s">
<EuiHealth textSize="inherit" color={getHealthColor(rule.executionStatus.status)}>
Expand All @@ -318,7 +318,7 @@ export function RuleDetailsPage() {
</EuiHealth>
</EuiTitle>
</EuiFlexItem>
<EuiSpacer size="l" />
<EuiSpacer size="m" />
<EuiFlexGroup>
<ItemTitleRuleSummary>
{i18n.translate('xpack.observability.ruleDetails.lastRun', {
Expand All @@ -330,11 +330,7 @@ export function RuleDetailsPage() {
itemValue={moment(rule.executionStatus.lastExecutionDate).fromNow()}
/>
</EuiFlexGroup>
<EuiSpacer size="xl" />

<EuiHorizontalRule margin="none" />
<EuiSpacer size="s" />

<EuiHorizontalRule margin="s" />
<EuiFlexGroup>
<ItemTitleRuleSummary>
{i18n.translate('xpack.observability.ruleDetails.alerts', {
Expand Down Expand Up @@ -376,16 +372,14 @@ export function RuleDetailsPage() {
/>
</EuiFlexGroup>
)}
<EuiSpacer size="l" />
<EuiSpacer size="l" />
</EuiFlexGroup>
</EuiPanel>
</EuiFlexItem>

{/* Right side of Rule Summary */}

<EuiFlexItem grow={3}>
<EuiPanel color="subdued" hasBorder={false} paddingSize={'l'}>
<EuiPanel color="subdued" hasBorder={false} paddingSize={'m'}>
<EuiFlexGroup justifyContent="spaceBetween">
<EuiTitle size="s">
<EuiFlexItem grow={false}>
Expand All @@ -401,7 +395,7 @@ export function RuleDetailsPage() {
)}
</EuiFlexGroup>

<EuiSpacer size="l" />
<EuiSpacer size="m" />

<EuiFlexGroup alignItems="baseline">
<EuiFlexItem>
Expand All @@ -416,9 +410,9 @@ export function RuleDetailsPage() {
/>
</EuiFlexGroup>

<EuiSpacer size="l" />
<EuiSpacer size="m" />

<EuiFlexGroup alignItems="flexStart">
<EuiFlexGroup alignItems="flexStart" responsive={false}>
<ItemTitleRuleSummary>
{i18n.translate('xpack.observability.ruleDetails.description', {
defaultMessage: 'Description',
Expand All @@ -429,7 +423,7 @@ export function RuleDetailsPage() {
/>
</EuiFlexGroup>

<EuiSpacer size="l" />
<EuiSpacer size="m" />

<EuiFlexGroup>
<ItemTitleRuleSummary>
Expand All @@ -449,8 +443,6 @@ export function RuleDetailsPage() {
</EuiFlexGroup>
</EuiFlexItem>
</EuiFlexGroup>

<EuiSpacer size="l" />
</EuiFlexItem>
<EuiFlexItem>
<EuiFlexGroup>
Expand All @@ -463,7 +455,7 @@ export function RuleDetailsPage() {
<ItemValueRuleSummary itemValue={formatInterval(rule.schedule.interval)} />
</EuiFlexGroup>

<EuiSpacer size="l" />
<EuiSpacer size="m" />

<EuiFlexGroup>
<ItemTitleRuleSummary>
Expand All @@ -474,7 +466,7 @@ export function RuleDetailsPage() {
<ItemValueRuleSummary itemValue={String(getNotifyText())} />
</EuiFlexGroup>

<EuiSpacer size="l" />
<EuiSpacer size="m" />
<EuiFlexGroup alignItems="baseline">
<ItemTitleRuleSummary>
{i18n.translate('xpack.observability.ruleDetails.actions', {
Expand Down