[SecuritySolution] Add session ID to highlighted fields #132219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janmonschke
added
release_note:enhancement
backport:skip
|
@elasticmachine merge upstream |
| @@ -9,6 +9,12 @@ export const mockAlertDetailsData = [ | |||
| { category: 'process', field: 'process.name', values: ['-'], originalValue: '-' }, | |||
| { category: 'process', field: 'process.pid', values: [0], originalValue: 0 }, | |||
| { category: 'process', field: 'process.executable', values: ['-'], originalValue: '-' }, | |||
| { | |||
| category: 'process', | |||
| field: 'process.entry_leader.entity_id', | |||
There was a problem hiding this comment.
Let's just confirm with the AWP team that this value is the best one for us to use. I think so, but want to make sure nothing has changed
There was a problem hiding this comment.
Confirmed with them offline 👍
michaelolo24
approved these changes
May 16, 2022
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @janmonschke |
|
Received an offline approval for the copy 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In order to highlight the amount of alerts that were generated in the same session, we're adding the session (leader) id to the highlighted fields in the alert flyout. (see #131943)
Note: The copy
Session IDis still pending review from @paulewingChecklist
Delete any items that are not applicable to this PR.