Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[es/healthcheck] ensure that healthcheck stops when server is stopped #13201

Merged
merged 2 commits into from
Aug 8, 2017

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Jul 28, 2017

While trying to write tests for #13079 I discovered that the healthcheck continues to run even after the server is closed. This fixed that by listening for the onPreStop event on the Hapi server, includes tests.

@spalger spalger force-pushed the fix/es/stop-healthcheck-on-shutdown branch from 2205697 to 60872cd Compare July 29, 2017 06:48
@jbudz
Copy link
Member

jbudz commented Jul 31, 2017

Chrome 59.0.3071 (Linux 0.0.0)  "after each" hook FAILED
	Error: Uncaught TypeError: Cannot read property 'key' of undefined (http://localhost:5610/bundles/tests.bundle.js?shards=4&shard_num=1:85272)
Chrome 59.0.3071 (Linux 0.0.0): Executed 835 of 838 (1 FAILED) (0 secs / 3.468 secs)
Chrome 59.0.3071 (Linux 0.0.0)  "after each" hook FAILED
	TypeError: Cannot read property '$injector' of null
	    at Context.<anonymous> (http://localhost:5610/bundles/tests.bundle.js?shards=4&shard_num=1:87254:32)
Chrome 59.0.3071 (Linux 0.0.0): Executed 836 of 838 (2 FAILED) (0 secs / 3.474 secs)
Chrome 59.0.3071 (Linux 0.0.0)  "after each" hook for "returns a function" FAILED
	TypeError: Cannot read property '$injector' of null
	    at Context.<anonymous> (http://localhost:5610/bundles/tests.bundle.js?shards=4&shard_num=1:87254:32)

@spalger
Copy link
Contributor Author

spalger commented Jul 31, 2017

@jbudz merging master fixed it

@tylersmalley
Copy link
Contributor

@spalger, is this good to merge?

@spalger spalger merged commit 9245488 into elastic:master Aug 8, 2017
@spalger spalger deleted the fix/es/stop-healthcheck-on-shutdown branch August 8, 2017 22:11
spalger added a commit to spalger/kibana that referenced this pull request Aug 8, 2017
spalger added a commit to spalger/kibana that referenced this pull request Aug 8, 2017
spalger added a commit that referenced this pull request Aug 8, 2017
spalger added a commit that referenced this pull request Aug 8, 2017
@spalger
Copy link
Contributor Author

spalger commented Aug 8, 2017

5.5: #13403
5.6: #13402
6.0: b3d8523
6.1/6.x: f66daee

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants