-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[es/healthcheck] ensure that healthcheck stops when server is stopped #13201
Merged
spalger
merged 2 commits into
elastic:master
from
spalger:fix/es/stop-healthcheck-on-shutdown
Aug 8, 2017
Merged
[es/healthcheck] ensure that healthcheck stops when server is stopped #13201
spalger
merged 2 commits into
elastic:master
from
spalger:fix/es/stop-healthcheck-on-shutdown
Aug 8, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
force-pushed
the
fix/es/stop-healthcheck-on-shutdown
branch
from
July 29, 2017 06:48
2205697
to
60872cd
Compare
|
…ealthcheck-on-shutdown
@jbudz merging master fixed it |
tylersmalley
approved these changes
Jul 31, 2017
jbudz
approved these changes
Jul 31, 2017
@spalger, is this good to merge? |
spalger
added a commit
to spalger/kibana
that referenced
this pull request
Aug 8, 2017
…elastic#13201) (cherry picked from commit 9245488)
spalger
added a commit
to spalger/kibana
that referenced
this pull request
Aug 8, 2017
…elastic#13201) (cherry picked from commit 9245488)
This was referenced Aug 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to write tests for #13079 I discovered that the healthcheck continues to run even after the server is closed. This fixed that by listening for the
onPreStop
event on the Hapi server, includes tests.