Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Session View] Close session viewer button fixes #131910

Merged
merged 3 commits into from
May 12, 2022

Conversation

opauloh
Copy link
Contributor

@opauloh opauloh commented May 10, 2022

Summary

This PR address fixes to #131102 by:

  • Updating the Close session button text to Close session viewer.
  • Adding <EuiHorizontalRule/> and <EuiSpacer/> before and after the Close session viewer button.
  • Changing the Session View wrapper div to only apply padding when entering FullScreen mode (also fixes [Session View] Session viewer container displaced #130140)

Screenshots

Close session viewer button on hosts page
image

Close session viewer button on fullscreen mode
image

Close session viewer button on timelines
image

Close session viewer button on users page
image

Additional Checks

  • Checked on Dark mode

@opauloh opauloh added bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v8.3.0 v8.2.1 labels May 10, 2022
@opauloh opauloh requested a review from a team as a code owner May 10, 2022 12:38
@opauloh opauloh enabled auto-merge (squash) May 12, 2022 19:43
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 5.0MB 5.0MB +493.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@opauloh opauloh merged commit dea7c19 into elastic:main May 12, 2022
kibanamachine pushed a commit that referenced this pull request May 12, 2022
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.2

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request May 12, 2022
(cherry picked from commit dea7c19)

Co-authored-by: Paulo Henrique <[email protected]>
Bamieh pushed a commit to Bamieh/kibana that referenced this pull request May 16, 2022
@opauloh opauloh added the Team: AWP: Visualization AWP team that does most fullstack work in kibana label May 16, 2022
@ghost
Copy link

ghost commented Jun 8, 2022

Hi @kqualters-elastic @opauloh,

We have Validated this issue on #130140 and it's working fine ✅.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team: AWP: Visualization AWP team that does most fullstack work in kibana v8.2.1 v8.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Session View] Session viewer container displaced
4 participants