Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding a11y tests for the new data grid in discover #131854

Merged
merged 14 commits into from
May 16, 2022
Merged

Adding a11y tests for the new data grid in discover #131854

merged 14 commits into from
May 16, 2022

Conversation

bhavyarm
Copy link
Contributor

@bhavyarm bhavyarm commented May 9, 2022 •
edited
Loading

Added new a11y tests for testing the new data grid in discover

@bhavyarm bhavyarm added Feature:Discover Discover Application Project:Accessibility release_note:skip Skip the PR/issue when compiling release notes v8.3.0 labels May 9, 2022
@bhavyarm bhavyarm self-assigned this May 9, 2022
@bhavyarm bhavyarm marked this pull request as ready for review May 10, 2022 16:13
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-accessibility (Project:Accessibility)

@bhavyarm bhavyarm requested review from kertal and jughosta May 10, 2022 16:13
jughosta
jughosta approved these changes May 11, 2022
View reviewed changes
Copy link
Contributor

@jughosta jughosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bhavyarm bhavyarm requested a review from jughosta May 16, 2022 14:31
@bhavyarm
Copy link
Contributor Author

Flaky test runner - https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/627

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @bhavyarm

@bhavyarm bhavyarm merged commit ee22d7e into elastic:main May 16, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label May 16, 2022
@bhavyarm bhavyarm mentioned this pull request Jun 21, 2022
Open
77 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jughosta jughosta jughosta approved these changes

@kertal kertal Awaiting requested review from kertal

Assignees

@bhavyarm bhavyarm

Labels
backport:skip This commit does not require backporting Feature:Discover Discover Application Project:Accessibility release_note:skip Skip the PR/issue when compiling release notes v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bhavyarm @elasticmachine @kibana-ci @jughosta @kibanamachine