-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds get all REST API to data views #131683
Conversation
src/plugins/data_views/server/rest_api_routes/get_data_views.ts
Outdated
Show resolved
Hide resolved
src/plugins/data_views/server/rest_api_routes/get_data_views.ts
Outdated
Show resolved
Hide resolved
Pinging @elastic/kibana-app-services (Team:AppServicesSv) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall it looks good but it would be good to add an api integration test. This is a good example - test/api_integration/apis/index_patterns/index_pattern_crud/get_index_pattern
"namespaces": [ | ||
"default" | ||
], | ||
"title": "tmp*", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this also return the type
if not default. add "type": "rollup"
to make this a rollup data view example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment about docs, otherwise good to go
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @lukasolson |
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Friendly reminder: Looks like this PR hasn’t been backported yet. |
5 similar comments
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Friendly reminder: Looks like this PR hasn’t been backported yet. |
💔 All backports failed
Manual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation |
Just a suggestion : It would be nice have append it with works perfect though! |
Summary
Closes #99928.
Adds a "get all" REST API for data views.
Example usage
Request:
Response:
Checklist
Release note
Adds a "get all" REST API for data views:
GET /api/data_views