Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution][Detections] Fixes Rule Execution Log events potentially being out of order when providing status filters and max events are hit #131675

Merged
merged 12 commits into from
Jul 11, 2022
Merged

[Security Solution][Detections] Fixes Rule Execution Log events potentially being out of order when providing status filters and max events are hit #131675

Changes from 2 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
0ab69a1
Fixes documents being out of order when providing status filters and …
spong May 5, 2022
2908958
Sort on timestamp from sub-agg
spong May 6, 2022
2496de2
Merge branch 'main' of github.com:elastic/kibana into fix-rule-execut…
spong May 16, 2022
42e813c
Merge branch 'main' into fix-rule-execution-log-overflow-sort
spong May 31, 2022
addf2e2
Merge branch 'main' into fix-rule-execution-log-overflow-sort
spong May 31, 2022
8a9a829
Merge branch 'main' into fix-rule-execution-log-overflow-sort
spong Jun 2, 2022
0073f02
Merge branch 'main' into fix-rule-execution-log-overflow-sort
spong Jun 8, 2022
746cf0f
Merge branch 'main' into fix-rule-execution-log-overflow-sort
kibanamachine Jul 8, 2022
5df5283
Merge branch 'main' into fix-rule-execution-log-overflow-sort
kibanamachine Jul 8, 2022
7a657ac
Adds api integration test
spong Jul 8, 2022
e12fecf
Merge branch 'main' into fix-rule-execution-log-overflow-sort
spong Jul 8, 2022
4f2eb52
Merge branch 'main' into fix-rule-execution-log-overflow-sort
spong Jul 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion ...ity_solution/server/lib/detection_engine/rule_execution_log/event_log/event_log_reader.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,16 @@ export const createEventLogReader = (eventLog: IEventLogClient): IEventLogReader
filteredExecutionUUIDs: {
terms: {
field: EXECUTION_UUID_FIELD,
order: { executeStartTime: 'desc' },
size: MAX_EXECUTION_EVENTS_DISPLAYED,
},
aggs: {
executeStartTime: {
min: {
field: '@timestamp',
},
},
},
},
},
});
Expand Down Expand Up @@ -113,7 +121,7 @@ export const createEventLogReader = (eventLog: IEventLogClient): IEventLogReader
maxExecutions: MAX_EXECUTION_EVENTS_DISPLAYED,
page,
perPage,
sort: [{ [sortField]: { order: sortOrder } }] as estypes.Sort,
sort: [{ [sortField]: { order: sortOrder } }],
}),
});

Expand Down