Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Clean up unused installed_bundled installation status #131558

Merged
merged 1 commit into from
May 4, 2022

Conversation

jen-huang
Copy link
Contributor

Summary

Clean up InstalledBundled: 'installed_bundled' package installation status, which is unused elsewhere in the code but creates a small amount of confusion. We track install source (bundled vs registry) via a different property, install_source: bundled.

@jen-huang jen-huang added technical debt Improvement of the software architecture and operational architecture release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.3.0 labels May 4, 2022
@jen-huang jen-huang self-assigned this May 4, 2022
@jen-huang jen-huang requested a review from a team as a code owner May 4, 2022 18:05
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
fleet 1275 1274 -1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
fleet 90.4KB 90.4KB -37.0B
Unknown metric groups

API count

id before after diff
fleet 1394 1393 -1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jen-huang

@jen-huang jen-huang merged commit 42ec15b into elastic:main May 4, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label May 4, 2022
@jen-huang jen-huang deleted the fix/cleanup-bundled-status branch May 4, 2022 20:50
kertal pushed a commit to kertal/kibana that referenced this pull request May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team technical debt Improvement of the software architecture and operational architecture v8.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants