Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Osquery pack attribution #131462

Merged
merged 5 commits into from
May 4, 2022

Conversation

melissaburpo
Copy link
Contributor

Summary

This change adds details about the new prebuilt Osquery packs that are available, including the source attribution for each.

@melissaburpo melissaburpo added auto-backport Deprecated - use backport:version if exact versions are needed v8.2.0 release_note:skip Skip the PR/issue when compiling release notes Team:Docs labels May 3, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

@melissaburpo
Copy link
Contributor Author

Hi @gchaps. This info seems like it might work better in a table, but I've added it as a list instead given some of the table layout issues. Please share any thoughts though if you'd like to try another approach for organizing the prebuilt pack reference content. Thanks!

@melissaburpo melissaburpo marked this pull request as draft May 4, 2022 15:18
@melissaburpo melissaburpo marked this pull request as ready for review May 4, 2022 15:49
Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please make sure that the link in the second sentence goes to the right location in the main Osquery doc.

docs/osquery/prebuilt-packs.asciidoc Outdated Show resolved Hide resolved
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@melissaburpo melissaburpo merged commit fb453ac into elastic:main May 4, 2022
@melissaburpo melissaburpo deleted the osquery-pack-attribution branch May 4, 2022 21:13
kibanamachine pushed a commit that referenced this pull request May 4, 2022
* add new reference page for prebuilt packs

* add link to new prebuilt pack ref page

* convert list to table

* add table close

* Apply suggestions from code review

Co-authored-by: gchaps <[email protected]>

Co-authored-by: gchaps <[email protected]>
(cherry picked from commit fb453ac)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.2

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request May 4, 2022
* add new reference page for prebuilt packs

* add link to new prebuilt pack ref page

* convert list to table

* add table close

* Apply suggestions from code review

Co-authored-by: gchaps <[email protected]>

Co-authored-by: gchaps <[email protected]>
(cherry picked from commit fb453ac)

Co-authored-by: Melissa Burpo <[email protected]>
kertal pushed a commit to kertal/kibana that referenced this pull request May 24, 2022
* add new reference page for prebuilt packs

* add link to new prebuilt pack ref page

* convert list to table

* add table close

* Apply suggestions from code review

Co-authored-by: gchaps <[email protected]>

Co-authored-by: gchaps <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Docs v8.2.0 v8.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants