[Discover] Fix adding a filter for scripted fields via Document Explorer cell actions #130895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jughosta
added
Feature:Discover
…ent Explorer view
jughosta
force-pushed
the
130751-document-explorer-scripted-field
branch
from
4c67cc5 to
3c79c71
Compare
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
kertal
approved these changes
Apr 26, 2022
| mode: '+' | '-' | ||
| ) { | ||
| const row = context.rows[rowIndex]; | ||
| const flattened = flattenHit(row, context.indexPattern); |
There was a problem hiding this comment.
just a side note, unrelated to this PR: we should not flatten our hits in the UI, too much flattening is being done a various places in Discover. We should migrate this to something like
data being fetched -> data being prepared (flattened) -> UI
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
jughosta
added a commit
to jughosta/kibana
that referenced
this pull request
Apr 26, 2022
…ent Explorer view (elastic#130895) (cherry picked from commit 60049fd) # Conflicts: # src/plugins/discover/public/components/discover_grid/discover_grid_cell_actions.tsx
jughosta
added a commit
that referenced
this pull request
Apr 26, 2022
… Document Explorer view (#130895) (#130996) * [Discover] Fix adding/removing a filter for a scripted field in Document Explorer view (#130895) (cherry picked from commit 60049fd) # Conflicts: # src/plugins/discover/public/components/discover_grid/discover_grid_cell_actions.tsx * [Discover] Revert paths for backporting
kertal
pushed a commit
to kertal/kibana
that referenced
this pull request
May 24, 2022
…ent Explorer view (elastic#130895)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #130751
Summary
This PR fixes adding filters when user clicks on "Filter for"/"Filter out" buttons in the new Document Explorer grid. Now field types will be considered and scripted fields will be properly handled in the search request. A similar implementation for the legacy table view can be found here.
How to test:
return "test";value+/-cell actions for Document Explorer and the legacy table view. It should trigger ES queries withscriptfilter. Same behaviour should be for+/-in Document Explorer flyout.Checklist