Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating managed agent manifest needed resources for cloudbeat #130886

Merged
merged 11 commits into from
May 4, 2022

Conversation

oren-zohar
Copy link
Contributor

@oren-zohar oren-zohar commented Apr 25, 2022

Summary

agent manifest needs more mounts and kube-api resources permissions for some of cloudbeat fetchers to work properly, see:

additionally, since cloudbeat will require custom agent deployment (like the Kuberentes package) we'll need to add our package into the custom agent manifest flow, where the user is promoted with a new manifest with the relevant permissions for the managed agent deployment

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@oren-zohar oren-zohar marked this pull request as ready for review April 28, 2022 07:50
@oren-zohar oren-zohar requested a review from a team as a code owner April 28, 2022 07:50
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Apr 28, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@oren-zohar oren-zohar changed the title agent manifest needed mounts for cloudbeat updating managed agent manifest needed resources for cloudbeat Apr 28, 2022
Copy link
Contributor

@juliaElastic juliaElastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oren-zohar
Copy link
Contributor Author

note: merge only after this PR is merged

@oren-zohar oren-zohar added v8.3.0 release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels May 4, 2022
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
fleet 1274 1275 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 702.4KB 702.4KB +58.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
fleet 90.3KB 90.4KB +137.0B
Unknown metric groups

API count

id before after diff
fleet 1393 1394 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@oren-zohar oren-zohar merged commit a1f8cd4 into elastic:main May 4, 2022
@oren-zohar oren-zohar deleted the elastic-agent-manifest-mounts branch May 4, 2022 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants