-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run tests in parallel in many detection_engine_api_integration data_types suites #130591
Closed
brianseeders
wants to merge
10
commits into
elastic:main
from
brianseeders:detection-engine-data-types
Closed
Run tests in parallel in many detection_engine_api_integration data_types suites #130591
brianseeders
wants to merge
10
commits into
elastic:main
from
brianseeders:detection-engine-data-types
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianseeders
added
Team:Operations
Team label for Operations Team
release_note:skip
Skip the PR/issue when compiling release notes
Feature:CI
Continuous integration
Team: SecuritySolution
Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
auto-backport
Deprecated - use backport:version if exact versions are needed
v8.3.0
v8.2.1
labels
Apr 21, 2022
Pinging @elastic/kibana-operations (Team:Operations) |
Pinging @elastic/security-solution (Team: SecuritySolution) |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport
Deprecated - use backport:version if exact versions are needed
Feature:CI
Continuous integration
release_note:skip
Skip the PR/issue when compiling release notes
Team:Operations
Team label for Operations Team
Team: SecuritySolution
Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
v8.2.1
v8.3.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI Group 24 is currently one of that longest parts of CI, clocking in at about 56 minutes. 50 minutes of that is just the
Detection exceptions data types and operators
tests. Rather than just breaking them out into multiple new CI Groups, I took a peek at them to see why they were taking so long. I noticed that it appeared that a lot of them could be run in parallel, so I refactored the two longest suites to run many of the test cases in parallel. The two of them together went from 17 minutes to about 3 minutes.The entire CI Group would probably only be about 10 minutes long if the other suites were refactored in a similar way.
This is what a failure now looks like:
Inside x-pack/test/detection_engine_api_integration/security_and_spaces/tests/exception_operators_data_types tests:
describe()
blocks, run them in parallel togetherLet me know what you folks think about this approach to these tests.