Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution][Legacy Actions] - Update legacy action migration to account for more edge cases #130511

Merged
merged 31 commits into from
May 4, 2022
Merged

[Security Solution][Legacy Actions] - Update legacy action migration to account for more edge cases #130511

Show file tree
Hide file tree
Changes from 23 commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
55e9c82
updating actions migration logic with added unit tests
yctercero Apr 1, 2022
f5428e8
updating e2d and unit tests
yctercero Apr 5, 2022
b5d71fc
Merge branch 'main' of github.com:elastic/kibana into updating_action…
yctercero Apr 18, 2022
5d18fdd
cleanup
yctercero Apr 18, 2022
bfa25f3
cleanup
yctercero Apr 18, 2022
524e102
cleanup
yctercero Apr 18, 2022
e756f27
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
kibanamachine Apr 18, 2022
bc1c965
need updates to jest tests, cleanup
yctercero Apr 19, 2022
0b4cbd5
Merge branch 'main' of github.com:elastic/kibana into updating_action…
yctercero Apr 19, 2022
8ac5522
Merge branch 'updating_actions_migration_logic' of github.com:ycterce…
yctercero Apr 19, 2022
f617c83
cleanup debugs
yctercero Apr 19, 2022
4cfe863
working on updting jest tests
yctercero Apr 19, 2022
f4e861f
Merge branch 'main' of github.com:elastic/kibana into updating_action…
yctercero Apr 19, 2022
1cf24fa
updated code and tests to add logic for multiple actions
yctercero Apr 20, 2022
5c37cab
Merge branch 'main' of github.com:elastic/kibana into updating_action…
yctercero Apr 20, 2022
fb9cc25
Merge branch 'main' of github.com:elastic/kibana into updating_action…
yctercero Apr 20, 2022
0f599b9
lint cleanup
yctercero Apr 20, 2022
1689670
update test util for consistency
yctercero Apr 20, 2022
816caec
cleanup
yctercero Apr 20, 2022
3cd9f1c
cleanup
yctercero Apr 20, 2022
157f28d
Merge branch 'main' of github.com:elastic/kibana into updating_action…
yctercero Apr 20, 2022
360d649
Merge branch 'main' into updating_actions_migration_logic
kibanamachine Apr 21, 2022
b6b3c71
Merge branch 'main' into updating_actions_migration_logic
kibanamachine Apr 21, 2022
e2ed435
Merge branch 'main' of github.com:yctercero/kibana into updating_acti…
yctercero Apr 25, 2022
dc2af16
updating tests per feedback
yctercero Apr 25, 2022
c648433
Merge branch 'updating_actions_migration_logic' of github.com:ycterce…
yctercero Apr 25, 2022
8ad20a3
Merge branch 'main' of github.com:elastic/kibana into updating_action…
yctercero Apr 26, 2022
1c1da12
fix errors post merge
yctercero Apr 26, 2022
68e8dff
Merge branch 'main' of github.com:elastic/kibana into updating_action…
yctercero May 3, 2022
2dd9b78
update test
yctercero May 3, 2022
b98f3da
fix esarchiver reference
yctercero May 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...rity_solution/server/lib/detection_engine/notifications/legacy_read_notifications.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ describe('legacyReadNotifications', () => {
id: undefined,
ruleAlertId: 'rule-1',
});
expect(rule).toEqual(legacyGetNotificationResult());
expect(rule).toEqual(legacyGetNotificationResult('123'));
});

test('should return null if the output from rulesClient with ruleAlertId set is empty', async () => {
Expand All @@ -127,7 +127,7 @@ describe('legacyReadNotifications', () => {
id: null,
ruleAlertId: 'rule-1',
});
expect(rule).toEqual(legacyGetNotificationResult());
expect(rule).toEqual(legacyGetNotificationResult('123'));
});

test('should return null if id and ruleAlertId are null', async () => {
Expand Down
Loading