Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add max configuration for minimumScheduleInterval and number of actions #130465

Merged
merged 3 commits into from
Apr 19, 2022

Conversation

mikecote
Copy link
Contributor

PR relates to #129128 but should follow up with cloud allow-list fixes if any. To be followed up by @ersin-erdal.

In this PR, I'm adding the following limitations to the new 8.2 config settings:

  • Can't set xpack.alerting.rules.execution.actions.max higher than 100,000
  • Can't set xpack.alerting.rules.minimumScheduleInterval to an interval greater than 1d

@mikecote mikecote added release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Alerting/RulesFramework Issues related to the Alerting Rules Framework v8.2.0 v8.3.0 labels Apr 18, 2022
@mikecote mikecote self-assigned this Apr 18, 2022
@mikecote mikecote marked this pull request as ready for review April 18, 2022 16:39
@mikecote mikecote requested a review from a team as a code owner April 18, 2022 16:39
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @mikecote

Copy link
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@ersin-erdal ersin-erdal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikecote mikecote added the auto-backport Deprecated - use backport:version if exact versions are needed label Apr 19, 2022
@mikecote mikecote merged commit d38333d into elastic:main Apr 19, 2022
kibanamachine pushed a commit that referenced this pull request Apr 19, 2022
…ns (#130465)

* Add max configuration for minimumScheduleInterval and number of actions

* Fix test execution -> run

(cherry picked from commit d38333d)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.2

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Apr 19, 2022
…ns (#130465) (#130552)

* Add max configuration for minimumScheduleInterval and number of actions

* Fix test execution -> run

(cherry picked from commit d38333d)

Co-authored-by: Mike Côté <[email protected]>
kertal pushed a commit to kertal/kibana that referenced this pull request May 24, 2022
…ns (elastic#130465)

* Add max configuration for minimumScheduleInterval and number of actions

* Fix test execution -> run
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Alerting/RulesFramework Issues related to the Alerting Rules Framework release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.2.0 v8.3.0
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

6 participants