[Cases] Revert preconfigured connectors support for Cases #130372

cnasikas · 2022-04-15T12:00:40Z

Summary

Reverts back the support of preconfigured connectors for Cases that was mistakenly removed in 7.17.0

Testing

Add a supported preconfigured connector to your kibana.dev.yml. It should be able to be used in Cases.

xpack.actions.preconfigured:
  preconfigured-servicenow:
    name: preconfigured-servicenow
    actionTypeId: .servicenow
    config:
      apiUrl: https://example/com
    secrets:
      username: <username>
      password: <password>

Video of the fix

preconf.mp4

Release notes

Revert back the support of preconfigured connectors for Cases that was mistakenly removed in 7.17.0

Checklist

Delete any items that are not applicable to this PR.

Unit or functional tests were updated or added to match the most common scenarios

For maintainers

This was checked for breaking API changes and was labeled appropriately

elasticmachine · 2022-04-19T09:02:33Z

Pinging @elastic/response-ops (Team:ResponseOps)

elasticmachine · 2022-04-19T09:02:34Z

Pinging @elastic/response-ops-cases (Feature:Cases)

academo

I don't clearly understand this part of the code but I can confirm I tested this locally and it works.

peteharverson

Tested locally and LGTM. Just a couple of minor edits suggested for the tests.

x-pack/plugins/cases/public/components/connectors/servicenow/validator.test.ts

kibana-ci · 2022-04-27T09:13:26Z

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`cases`	288.5KB	288.7KB	+194.0B

History

💔 Build #40547 failed 4201888
💚 Build #39096 succeeded 152e4e5
💔 Build #39091 failed f117f09
💔 Build #39052 failed 60b9174acd78711ece4186044098a3e9b0310fa8
💔 Build #38964 failed cad32ca

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @cnasikas

…0372) * Fix bug with deprecated connectors * Add integration test * Improve integration tests * Fix grammar * Fix CI Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit 12fdfd6) # Conflicts: # x-pack/plugins/cases/server/client/configure/client.test.ts

…0372) * Fix bug with deprecated connectors * Add integration test * Improve integration tests * Fix grammar * Fix CI Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit 12fdfd6) # Conflicts: # x-pack/plugins/cases/public/components/connectors/servicenow/servicenow_itsm_case_fields.test.tsx # x-pack/plugins/cases/public/components/connectors/servicenow/servicenow_sir_case_fields.test.tsx # x-pack/plugins/cases/server/client/configure/client.test.ts # x-pack/test/case_api_integration/security_and_spaces/tests/basic/configure/create_connector.ts # x-pack/test/case_api_integration/security_and_spaces/tests/basic/configure/get_connectors.ts # x-pack/test/case_api_integration/security_and_spaces/tests/common/configure/get_connectors.ts # x-pack/test/cases_api_integration/common/config.ts # x-pack/test/cases_api_integration/common/lib/utils.ts # x-pack/test/cases_api_integration/security_and_spaces/tests/common/configure/get_connectors.ts # x-pack/test/cases_api_integration/security_and_spaces/tests/common/index.ts # x-pack/test/cases_api_integration/security_and_spaces/tests/trial/configure/get_connectors.ts # x-pack/test/cases_api_integration/spaces_only/tests/trial/configure/get_connectors.ts

) (#131043) * [Cases] Revert preconfigured connectors support for Cases (#130372) * Fix bug with deprecated connectors * Add integration test * Improve integration tests * Fix grammar * Fix CI Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit 12fdfd6) # Conflicts: # x-pack/plugins/cases/server/client/configure/client.test.ts * Fix linting

…0372) (#131046) * [Cases] Revert preconfigured connectors support for Cases (#130372) * Fix bug with deprecated connectors * Add integration test * Improve integration tests * Fix grammar * Fix CI Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit 12fdfd6) # Conflicts: # x-pack/plugins/cases/public/components/connectors/servicenow/servicenow_itsm_case_fields.test.tsx # x-pack/plugins/cases/public/components/connectors/servicenow/servicenow_sir_case_fields.test.tsx # x-pack/plugins/cases/server/client/configure/client.test.ts # x-pack/test/case_api_integration/security_and_spaces/tests/basic/configure/create_connector.ts # x-pack/test/case_api_integration/security_and_spaces/tests/basic/configure/get_connectors.ts # x-pack/test/case_api_integration/security_and_spaces/tests/common/configure/get_connectors.ts # x-pack/test/cases_api_integration/common/config.ts # x-pack/test/cases_api_integration/common/lib/utils.ts # x-pack/test/cases_api_integration/security_and_spaces/tests/common/configure/get_connectors.ts # x-pack/test/cases_api_integration/security_and_spaces/tests/common/index.ts # x-pack/test/cases_api_integration/security_and_spaces/tests/trial/configure/get_connectors.ts # x-pack/test/cases_api_integration/spaces_only/tests/trial/configure/get_connectors.ts * Fix tests Co-authored-by: Kibana Machine <[email protected]>

…) (#131041) Co-authored-by: Kibana Machine <[email protected]>

…0372) * Fix bug with deprecated connectors * Add integration test * Improve integration tests * Fix grammar * Fix CI Co-authored-by: Kibana Machine <[email protected]>

cnasikas added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Cases Cases feature auto-backport Deprecated - use backport:version if exact versions are needed v8.2.0 v8.0.2 v8.3.0 v8.1.3 v7.17.4 labels Apr 15, 2022

cnasikas self-assigned this Apr 15, 2022

cnasikas changed the title ~~[] Revert preconfigured connectors support for Cases~~ [Cases] Revert preconfigured connectors support for Cases Apr 15, 2022

cnasikas added v8.2.1 and removed v8.0.2 v8.1.3 v8.2.0 labels Apr 15, 2022

Fix bug with deprecated connectors

af7db42

cnasikas force-pushed the pre_conf_connectors branch 2 times, most recently from 32e016a to af7db42 Compare April 19, 2022 07:38

Add integration test

cad32ca

cnasikas marked this pull request as ready for review April 19, 2022 09:02

cnasikas requested a review from a team as a code owner April 19, 2022 09:02

cnasikas requested a review from academo April 19, 2022 09:02

cnasikas added the release_note:fix label Apr 19, 2022

academo approved these changes Apr 19, 2022

View reviewed changes

Improve integration tests

f117f09

cnasikas force-pushed the pre_conf_connectors branch from 60b9174 to f117f09 Compare April 19, 2022 14:22

peteharverson approved these changes Apr 19, 2022

View reviewed changes

x-pack/plugins/cases/public/components/connectors/servicenow/validator.test.ts Outdated Show resolved Hide resolved

x-pack/plugins/cases/public/components/connectors/servicenow/validator.test.ts Outdated Show resolved Hide resolved

Fix grammar

152e4e5

cnasikas mentioned this pull request Apr 20, 2022

[Cases] Show an icon for preconfigured connectors in the dropdowns #130640

Closed

This was referenced Apr 26, 2022

[DOCS] Remove note that pre-configured connectors are not supported on cases elastic/security-docs#1903

Closed

[DOCS] 7.17.4 Release Notes elastic/security-docs#1898

Merged

cnasikas added v8.0.2 v8.1.4 8.2.2 v8.2.1 and removed v8.2.1 8.2.2 auto-backport Deprecated - use backport:version if exact versions are needed labels Apr 27, 2022

Fix CI

0576128

cnasikas enabled auto-merge (squash) April 27, 2022 08:43

cnasikas merged commit 12fdfd6 into elastic:main Apr 27, 2022

cnasikas deleted the pre_conf_connectors branch April 27, 2022 09:13

cnasikas mentioned this pull request Apr 27, 2022

[8.2][Cases] Revert preconfigured connectors support for Cases (#130372) #131041

Merged

cnasikas mentioned this pull request Apr 27, 2022

[8.1] [Cases] Revert preconfigured connectors support for Cases (#130372) #131043

Merged

cnasikas mentioned this pull request Apr 27, 2022

[8.0] [Cases] Revert preconfigured connectors support for Cases (#130372) #131044

Closed

cnasikas mentioned this pull request Apr 27, 2022

[7.17] [Cases] Revert preconfigured connectors support for Cases (#130372) #131046

Merged

cnasikas added backport:skip This commit does not require backporting and removed backport:skip This commit does not require backporting v8.0.2 labels Apr 28, 2022

cnasikas added a commit that referenced this pull request May 4, 2022

[8.2][Cases] Revert preconfigured connectors support for Cases (#130372…

f808e03

…) (#131041) Co-authored-by: Kibana Machine <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Cases] Revert preconfigured connectors support for Cases #130372

[Cases] Revert preconfigured connectors support for Cases #130372

cnasikas commented Apr 15, 2022 •

edited by peteharverson

Loading

elasticmachine commented Apr 19, 2022

elasticmachine commented Apr 19, 2022

academo left a comment

peteharverson left a comment

kibana-ci commented Apr 27, 2022

[Cases] Revert preconfigured connectors support for Cases #130372

[Cases] Revert preconfigured connectors support for Cases #130372

Conversation

cnasikas commented Apr 15, 2022 • edited by peteharverson Loading

Summary

Testing

Video of the fix

Release notes

Checklist

For maintainers

elasticmachine commented Apr 19, 2022

elasticmachine commented Apr 19, 2022

academo left a comment

Choose a reason for hiding this comment

peteharverson left a comment

Choose a reason for hiding this comment

kibana-ci commented Apr 27, 2022

💚 Build Succeeded

Metrics [docs]

Async chunks

History

cnasikas commented Apr 15, 2022 •

edited by peteharverson

Loading