Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.2] [Discover] Unskip security tests (#130083) #130235

Merged
merged 1 commit into from
Apr 14, 2022
Merged

[8.2] [Discover] Unskip security tests (#130083) #130235

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/plugins/kibana_overview/public/components/overview/__snapshots__/overview.test.tsx.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions src/plugins/kibana_overview/public/components/overview/overview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ export const Overview: FC<Props> = ({ newsFetchResult, solutions, features }) =>
defaultMessage:
'Use Elastic Agent or Beats to collect data and build out Analytics solutions.',
}),
'data-test-subj': 'kbnOverviewAddIntegrations',
},
},
docsLink: docLinks.links.kibana.guide,
Expand Down
3 changes: 1 addition & 2 deletions x-pack/test/functional/apps/discover/feature_controls/discover_security.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
await PageObjects.timePicker.setDefaultAbsoluteRange();
}

// Failing: See https://github.com/elastic/kibana/issues/106631
describe.skip('discover feature controls security', () => {
describe('discover feature controls security', () => {
before(async () => {
await kibanaServer.importExport.load(
'x-pack/test/functional/fixtures/kbn_archiver/discover/feature_controls/security'
Expand Down
12 changes: 6 additions & 6 deletions x-pack/test/functional/apps/discover/feature_controls/discover_spaces.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,14 +28,12 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
await PageObjects.timePicker.setDefaultAbsoluteRange();
}

// Failing: See https://github.com/elastic/kibana/issues/113067
describe.skip('spaces', () => {
describe('spaces', () => {
before(async () => {
await esArchiver.loadIfNeeded('x-pack/test/functional/es_archives/logstash_functional');
});

// FLAKY: https://github.com/elastic/kibana/issues/60559
describe.skip('space with no features disabled', () => {
describe('space with no features disabled', () => {
before(async () => {
// we need to load the following in every situation as deleting
// a space deletes all of the associated saved objects
Expand Down Expand Up @@ -174,13 +172,15 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
await spacesService.delete('custom_space_no_index_patterns');
});

it('Navigates to Kibana home rather than index pattern management when no index patterns exist', async () => {
it('Navigates to Kibana Analytics overview when no data views exist', async () => {
await PageObjects.common.navigateToUrl('discover', '', {
basePath: '/s/custom_space_no_index_patterns',
ensureCurrentUrl: false,
shouldUseHashForSubUrl: false,
});
await testSubjects.existOrFail('homeApp', { timeout: config.get('timeouts.waitFor') });
await testSubjects.existOrFail('kbnOverviewAddIntegrations', {
timeout: config.get('timeouts.waitFor'),
});
});
});
});
Expand Down