Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Unskip security tests #130083

Merged
merged 7 commits into from
Apr 14, 2022

Conversation

kertal
Copy link
Member

@kertal kertal commented Apr 13, 2022

Summary

Fixes #106631
Fixes #60559
Closes #117059

This PR unskips discover security related tests. No changes were necessary to reduce flakiness, the flaky test runner with 100 runs surfaced no failure. One test is fixed since when there's data view available, Discover no longer navigates to Stack Management, there's a new Analytics page for that state.

Flaky test runner, 100 runs, no failure: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/457

Checklist

@kertal kertal self-assigned this Apr 13, 2022
@kertal kertal added Feature:Discover Discover Application Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Apr 13, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
kibanaOverview 10.3KB 10.4KB +46.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kertal

@kertal kertal marked this pull request as ready for review April 14, 2022 09:41
@kertal kertal requested a review from a team as a code owner April 14, 2022 09:41
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@kertal kertal requested a review from a team April 14, 2022 09:41
@kertal kertal added v8.3.0 v8.2.0 release_note:skip Skip the PR/issue when compiling release notes labels Apr 14, 2022
Copy link
Contributor

@jughosta jughosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating and reenabling tests!

@kertal kertal added the auto-backport Deprecated - use backport:version if exact versions are needed label Apr 14, 2022
@kertal kertal merged commit 37ebf93 into elastic:main Apr 14, 2022
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.2

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment