[Fleet] Only expose minimum needed config to browser #129619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshdover
added
Team:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
jen-huang
approved these changes
Apr 6, 2022
| @@ -47,7 +47,9 @@ const DEFAULT_BUNDLED_PACKAGE_LOCATION = path.join(__dirname, '../target/bundled | |||
| export const config: PluginConfigDescriptor = { | |||
| exposeToBrowser: { | |||
| epm: true, | |||
There was a problem hiding this comment.
could we remove this line too? we don't have any epm.* configs
jen-huang
added
the
release_note:skip
💛 Build succeeded, but was flakyTest Failures
Metrics [docs]
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
that referenced
this pull request
Apr 6, 2022
(cherry picked from commit 5a06e8f)
kibanamachine
pushed a commit
that referenced
this pull request
Apr 6, 2022
(cherry picked from commit 5a06e8f)
kibanamachine
pushed a commit
that referenced
this pull request
Apr 6, 2022
(cherry picked from commit 5a06e8f)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Apr 6, 2022
(cherry picked from commit 5a06e8f) Co-authored-by: Josh Dover <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Apr 6, 2022
(cherry picked from commit 5a06e8f) Co-authored-by: Josh Dover <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Apr 6, 2022
(cherry picked from commit 5a06e8f) Co-authored-by: Josh Dover <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This changes Fleet's config to only expose the
xpack.fleet.agents.enabledflag instead of the entirexpack.fleet.agents.*object to the browser. The other flags were unused.