-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dashboard] Explicitly Hide Panel Titles Migration #129540
[Dashboard] Explicitly Hide Panel Titles Migration #129540
Conversation
… titles were hidden in 7.9
Pinging @elastic/kibana-presentation (Team:Presentation) |
'7.11.0': flow(createExtractPanelReferencesMigration(deps)), | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, pending the change to 7.17.3
@@ -257,14 +307,8 @@ export const createDashboardSavedObjectTypeMigrations = ( | |||
'7.0.0': flow(migrations700), | |||
'7.3.0': flow(migrations730), | |||
'7.9.3': flow(migrateMatchAllQuery), | |||
'7.10.0': flow(migrateExplicitlyHiddenTitles), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's change this to happen in 7.17.3 to pick up all the cases of instances that are already past 7.10 who are still having the issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even though it's very unlikely that this change will actually be able to fix any cases, due to most of the in-between versions not having #95355, I think this is a good call, just in case. It can't hurt anything.
Will update the version!
…citlyHideTitles710
…m/ThomThomson/kibana into dashboard/explicitlyHideTitles710
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
* add dashboard migration to explicitly hide the titles on panels whose titles were hidden in 7.9 (cherry picked from commit c72a954)
* add dashboard migration to explicitly hide the titles on panels whose titles were hidden in 7.9 (cherry picked from commit c72a954)
* add dashboard migration to explicitly hide the titles on panels whose titles were hidden in 7.9 (cherry picked from commit c72a954)
* add dashboard migration to explicitly hide the titles on panels whose titles were hidden in 7.9 (cherry picked from commit c72a954)
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
Summary
Fixes #129386
Closes #122878 as this is the third and final part of the fix for that.
This PR adds a migration to dashboard for version 7.10 which finds all panels saved with a blank string panel title and turns on the
hidePanelTItles
setting for them.To test locally, you can import the following NDJSON from 7.9.3 which has 3 hidden titles and one shown title.
After the migration into main, the dashboard should have 3 hidden titles and one shown: