Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Unified Observability] Fix shadow for overview panels #128878

Merged
merged 2 commits into from
Apr 1, 2022
Merged

[Unified Observability] Fix shadow for overview panels #128878

merged 2 commits into from
Apr 1, 2022

Conversation

estermv
Copy link
Contributor

@estermv estermv commented Mar 30, 2022

Summary

Closes #126766. Small fix for the panels' shadow.

Before
Screenshot 2022-03-30 at 13 16 17

After
Screenshot 2022-03-30 at 13 07 30
Screenshot 2022-03-30 at 13 13 10

@estermv estermv added release_note:fix auto-backport Deprecated - use backport:version if exact versions are needed Team:Unified observability v8.2.0 labels Mar 30, 2022
@estermv estermv requested a review from a team as a code owner March 30, 2022 11:18
@elasticmachine
Copy link
Contributor

Pinging @elastic/unified-observability (Team:Unified observability)

@estermv estermv requested review from formgeist and a team March 30, 2022 11:19
formgeist
formgeist approved these changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@formgeist formgeist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢 Maybe we can also remove the unnecessary hasShadow prop on the main SectionContainer because it's ignored when the color is defined, afaict

kibana/x-pack/plugins/observability/public/components/app/section/index.tsx

Line 45 in edf2c4f

<EuiPanel hasShadow={true} color="subdued">

@estermv estermv requested a review from a team March 30, 2022 13:23
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 426.6KB 426.6KB -13.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

afgomez
afgomez approved these changes Apr 1, 2022
View reviewed changes
Copy link
Contributor

@afgomez afgomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@estermv estermv added the v8.3.0 label Apr 1, 2022
@estermv estermv merged commit f9d83f9 into elastic:main Apr 1, 2022
@estermv estermv deleted the 126766-fix-overview-panels-shadow branch April 1, 2022 09:02
kibanamachine pushed a commit that referenced this pull request Apr 1, 2022
@estermv
[Unified Observability] Fix shadow for overview panels (#128878)
bc54b24 
* replace shadow with border for overview panels

* remove not needed prop

(cherry picked from commit f9d83f9)
@kibanamachine kibanamachine mentioned this pull request Apr 1, 2022
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.2

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Apr 1, 2022
@kibanamachine @estermv
[Unified Observability] Fix shadow for overview panels (#128878) (#12…
bc9fbd8 
…9172)

* replace shadow with border for overview panels

* remove not needed prop

(cherry picked from commit f9d83f9)

Co-authored-by: Ester Martí Vilaseca <[email protected]>
@KOTungseth KOTungseth added the Team:Observability Team label for Observability Team (for things that are handled across all of observability) label Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@formgeist formgeist formgeist approved these changes

@afgomez afgomez afgomez approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:fix Team:Observability Team label for Observability Team (for things that are handled across all of observability) Team:Unified observability v8.2.0 v8.3.0
Projects
None yet
Milestone
No milestone
7 participants
@estermv @elasticmachine @kibana-ci @kibanamachine @afgomez @formgeist @KOTungseth