Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution][Endpoint] Fix event filter creation success toast #128810

Conversation

ashokaditya
Copy link
Member

Summary

Shows a success toast when the first-ever event filter is added to the event filters page.

clip showing add/edit
ef-creation

Checklist

@ashokaditya ashokaditya added bug Fixes for quality problems that affect the customer experience release_note:fix Team:Defend Workflows “EDR Workflows” sub-team of Security Solution auto-backport Deprecated - use backport:version if exact versions are needed v8.2.0 labels Mar 29, 2022
@ashokaditya ashokaditya self-assigned this Mar 29, 2022
@ashokaditya ashokaditya marked this pull request as ready for review March 29, 2022 19:16
@ashokaditya ashokaditya requested a review from a team as a code owner March 29, 2022 19:16
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt)

@ashokaditya ashokaditya changed the title Fix/olm 128444 fix event filter creation success toast [Security Solution][Endpoint] Fix event filter creation success toast Mar 29, 2022
@ashokaditya ashokaditya enabled auto-merge (squash) March 29, 2022 20:26
@ashokaditya ashokaditya merged commit d579ea7 into elastic:main Mar 29, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled in files

id before after diff
apm 15 14 -1
osquery 5 4 -1
securitySolution 69 68 -1
uptime 7 6 -1
total -4

ESLint disabled line counts

id before after diff
apm 88 85 -3
enterpriseSearch 9 7 -2
fleet 47 46 -1
osquery 122 119 -3
uptime 49 43 -6
total -15

References to deprecated APIs

id before after diff
canvas 70 64 -6
dashboard 78 72 -6
data 475 465 -10
dataEnhanced 55 49 -6
discover 26 20 -6
fleet 20 19 -1
lens 18 14 -4
management 2 1 -1
maps 456 330 -126
monitoring 40 28 -12
upgradeAssistant 12 7 -5
visDefaultEditor 205 155 -50
visTypeVega 4 3 -1
visualizations 17 13 -4
total -238

Total ESLint disabled count

id before after diff
apm 103 99 -4
enterpriseSearch 9 7 -2
fleet 55 54 -1
osquery 127 123 -4
securitySolution 509 508 -1
uptime 56 49 -7
total -19

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @ashokaditya

@kibanamachine
Copy link
Contributor

⚪ Backport skipped

The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.

Manual backport

To create the backport manually run:

node scripts/backport --pr 128810

Questions ?

Please refer to the Backport tool documentation

@ashokaditya ashokaditya deleted the fix/olm-128444-fix-event-filter-creation-success-toast branch March 30, 2022 06:53
@ashokaditya ashokaditya added backport:skip This commit does not require backporting and removed auto-backport Deprecated - use backport:version if exact versions are needed labels Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting bug Fixes for quality problems that affect the customer experience release_note:fix Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants