Should only fit on shapes that are part of the result #12881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins, test this |
thomasneirynck
changed the title
thomasneirynck
added
Feature:Visualizations
ppisljar
approved these changes
Jul 17, 2017
spalger
approved these changes
Jul 20, 2017
| } | ||
| }; | ||
| } | ||
|
|
||
| const { min, max } = getMinMax(data); | ||
| const outstandingFeatures = data.slice(); | ||
|
|
||
|
|
||
| const joinedShapes = []; |
There was a problem hiding this comment.
I think this would be a little easier for me to understand if we tracked the bounds here, extended it on each call to getLeafletStyleFunction, and just returned the current version in getLeafletBounds().
let bounds = new L.LatLngBounds()
...
bounds = bounds.extend(L.geoJson(shape).getBounds())
...
return bounds;
thomasneirynck
force-pushed
the
fix/fit_on_choropleth
branch
from
fdc0408 to
0bd8008
Compare
|
jenkins, test this |
thomasneirynck
force-pushed
the
fix/fit_on_choropleth
branch
from
0bd8008 to
0ee9054
Compare
|
jenkins, test this |
thomasneirynck
force-pushed
the
fix/fit_on_choropleth
branch
from
0ee9054 to
bd626ce
Compare
|
jenkins, test this |
thomasneirynck
force-pushed
the
fix/fit_on_choropleth
branch
from
bd626ce to
ab29e41
Compare
thomasneirynck
added a commit
to thomasneirynck/kibana
that referenced
this pull request
Jul 24, 2017
thomasneirynck
added a commit
to thomasneirynck/kibana
that referenced
this pull request
Jul 24, 2017
thomasneirynck
added a commit
that referenced
this pull request
Jul 24, 2017
thomasneirynck
added a commit
that referenced
this pull request
Jul 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Note: When clicking the fit-data button in a Region Map, the map now zooms correctly to the relevant data instead of showing the entire layer.
Closes #12220.