Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Cleanup discover_enhanced removing deprecated API usage #128713

Merged
merged 2 commits into from
Mar 29, 2022
Merged

[Discover] Cleanup discover_enhanced removing deprecated API usage #128713

merged 2 commits into from
Mar 29, 2022

Conversation

kertal
Copy link
Member

@kertal kertal commented Mar 29, 2022 •
edited
Loading

Summary

This PR cleans up deprecated API usage in x-pack/plugins/discover_enhanced

  • import of Filter, RangeFilter are now from '@kbn/es-query';

  • extractTimeRange is now imported directly form data without esFilters

@kertal kertal added Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.2.0 labels Mar 29, 2022
@kertal kertal self-assigned this Mar 29, 2022
@kertal kertal marked this pull request as ready for review March 29, 2022 07:29
@kertal kertal requested a review from a team as a code owner March 29, 2022 07:29
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@kertal kertal added chore technical debt Improvement of the software architecture and operational architecture labels Mar 29, 2022
@kertal kertal changed the title [Discover] enhanced cleanup deprecated [Discover] Cleanup discover_enhanced removing deprecated API usage Mar 29, 2022
@kertal kertal requested a review from dimaanj March 29, 2022 08:16
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
discoverEnhanced 5.4KB 5.3KB -2.0B
Unknown metric groups

References to deprecated APIs

id before after diff
discoverEnhanced 21 0 -21

Unreferenced deprecated APIs

id before after diff
data 56 58 +2

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kertal

dimaanj
dimaanj approved these changes Mar 29, 2022
View reviewed changes
Copy link
Contributor

@dimaanj dimaanj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code LGTM.

jughosta
jughosta approved these changes Mar 29, 2022
View reviewed changes
Copy link
Contributor

@jughosta jughosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kertal kertal merged commit 95ba4f8 into elastic:main Mar 29, 2022
@kertal kertal mentioned this pull request Mar 30, 2022
Closed
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 31, 2022
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 128713 or prevent reminders by adding the backport:skip label.

1 similar comment
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 128713 or prevent reminders by adding the backport:skip label.

@kertal kertal added the backport:skip This commit does not require backporting label Apr 1, 2022
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimaanj dimaanj dimaanj approved these changes

@jughosta jughosta jughosta approved these changes

Assignees

@kertal kertal

Labels
backport:skip This commit does not require backporting chore Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. technical debt Improvement of the software architecture and operational architecture v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kertal @elasticmachine @kibana-ci @kibanamachine @jughosta @dimaanj