Bump @elastic/request-crypto from v2.0.0 to v2.0.1 #128710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
watson
added
release_note:skip
watson
commented
Mar 29, 2022
| @@ -20710,7 +20723,12 @@ [email protected], node-fetch@^1.0.1, node-fetch@^2.3.0, node-fetch@^2.6.1, node- | |||
| dependencies: | |||
| whatwg-url "^5.0.0" | |||
|
|
|||
| node-forge@^0.10.0, node-forge@^1.3.0: | |||
| node-forge@^0.10.0: | |||
There was a problem hiding this comment.
Note to reviewers: The old node-forge dependency is a devDependency
azasypkin
approved these changes
Mar 29, 2022
| @@ -16378,7 +16386,7 @@ ieee754@^1.1.12, ieee754@^1.1.4: | |||
| resolved "https://registry.yarnpkg.com/ieee754/-/ieee754-1.1.13.tgz#ec168558e95aa181fd87d37f55c32bbcb6708b84" | |||
| integrity sha512-4vf7I2LYV/HaWerSo3XmlMkp5eZ83i+/CDluXi/IGTs/O1sejBNhTtnxzmRZfvOUqj7lZjqHkeTvpgSFDlWZTg== | |||
|
|
|||
| ieee754@^1.1.13: | |||
| ieee754@^1.1.13, ieee754@^1.2.1: | |||
There was a problem hiding this comment.
nit: looks like you can merge this declaration with another ieee754 declaration above.
There was a problem hiding this comment.
Ah, didn't notice enabled auto-merge 😢
There was a problem hiding this comment.
Ah good catch. I created a follow up PR: #129159
jportner
pushed a commit
to jportner/kibana
that referenced
this pull request
Apr 25, 2022
(cherry picked from commit 7cb7201)
jportner
added a commit
that referenced
this pull request
Apr 25, 2022
(cherry picked from commit 7cb7201) Co-authored-by: Thomas Watson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.