Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Cleanup usage of deprecated APIs #128602

Merged
merged 4 commits into from
Mar 29, 2022
Merged

[Discover] Cleanup usage of deprecated APIs #128602

merged 4 commits into from
Mar 29, 2022

Conversation

kertal
Copy link
Member

@kertal kertal commented Mar 28, 2022 •
edited
Loading

Summary

This PR is cleaning up remaining deprecated UI usage in src/plugin/discover

  • fieldFormats are now directly used (since they were extracted of the data plugin)

  • migrate remaining imports of Filter from '@kbn/es-query' away from data

  • One more IndexPattern -> DataView cleanup

  • And some minor 🧹

@kertal kertal self-assigned this Mar 28, 2022
@kertal kertal added Feature:Discover Discover Application Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. chore v8.2.0 release_note:skip Skip the PR/issue when compiling release notes labels Mar 28, 2022
@kertal kertal marked this pull request as ready for review March 28, 2022 16:14
@kertal kertal requested a review from a team as a code owner March 28, 2022 16:14
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@kertal kertal requested a review from dimaanj March 28, 2022 16:14
@kertal
Copy link
Member Author

kertal commented Mar 28, 2022

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 381.2KB 381.2KB +8.0B
Unknown metric groups

References to deprecated APIs

id before after diff
discover 44 26 -18

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kertal

dimaanj
dimaanj approved these changes Mar 29, 2022
View reviewed changes
Copy link
Contributor

@dimaanj dimaanj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code LGTM.

@kertal kertal added the technical debt Improvement of the software architecture and operational architecture label Mar 29, 2022
@kertal kertal merged commit 617bb30 into elastic:main Mar 29, 2022
@kertal kertal mentioned this pull request Mar 30, 2022
Closed
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 128602 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 31, 2022
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 128602 or prevent reminders by adding the backport:skip label.

@kertal kertal added the backport:skip This commit does not require backporting label Apr 1, 2022
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimaanj dimaanj dimaanj approved these changes

@jughosta jughosta jughosta approved these changes

Assignees

@kertal kertal

Labels
backport:skip This commit does not require backporting chore Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. technical debt Improvement of the software architecture and operational architecture v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kertal @elasticmachine @kibana-ci @kibanamachine @jughosta @dimaanj