Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Graph] Clean up deprecated APIs #128579

Merged
merged 4 commits into from
Mar 29, 2022
Merged

[Graph] Clean up deprecated APIs #128579

merged 4 commits into from
Mar 29, 2022

Conversation

dimaanj
Copy link
Contributor

@dimaanj dimaanj commented Mar 28, 2022

Summary

Closes #127714

Replacing of legacy IndexPattern type imports with DataView types.

@dimaanj dimaanj added Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.2.0 labels Mar 28, 2022
@dimaanj dimaanj self-assigned this Mar 28, 2022
@dimaanj
Copy link
Contributor Author

dimaanj commented Mar 28, 2022

@elasticmachine merge upstream

@kertal
Copy link
Member

kertal commented Mar 28, 2022

think you should label it [Graph]

@dimaanj dimaanj changed the title [Discover] Clean up deprecated APIs [Graph] Clean up deprecated APIs Mar 28, 2022
@dimaanj dimaanj marked this pull request as ready for review March 28, 2022 13:48
@dimaanj dimaanj requested a review from a team as a code owner March 28, 2022 13:48
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

kertal
kertal reviewed Mar 29, 2022
View reviewed changes
Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dmitriynj LGTM, except 1 more potential cleanup:

kibana/x-pack/plugins/graph/public/components/workspace_layout/workspace_layout.tsx

Line 20 in 7fff05f

import { IndexPattern } from '../../../../../../src/plugins/data/public';

kertal
kertal approved these changes Mar 29, 2022
View reviewed changes
Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can be merged once CI is green, thx! 👍

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
graph 163 221 +58

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
graph 449.4KB 476.8KB +27.4KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
graph 7.1KB 7.1KB +58.0B
Unknown metric groups

References to deprecated APIs

id before after diff
graph 178 22 -156

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dmitriynj

@dimaanj dimaanj merged commit 91394d4 into elastic:main Mar 29, 2022
@kertal kertal added the chore label Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kertal kertal kertal approved these changes

Assignees

@dimaanj dimaanj

Labels
backport:skip This commit does not require backporting chore Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Graph] Cleanup usage of deprecated APIs
5 participants
@dimaanj @kertal @elasticmachine @kibana-ci @kibanamachine