Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add imports for SavedObjectRegistryProvider.register, fixing Timelion #12844

Merged
merged 2 commits into from
Jul 13, 2017

Conversation

kobelb
Copy link
Contributor

@kobelb kobelb commented Jul 13, 2017

When other applications didn't have an import for the savedDashboards/savedSearches/etc. if it tried to import them using the uiExports.uses it wasn't working. This resolves that issue, and modified Timelion to "use" the savedObjectTypes

@spalger spalger merged commit 8f34633 into elastic:master Jul 13, 2017
@spalger spalger removed the v5.6.0 label Jul 13, 2017
@spalger
Copy link
Contributor

spalger commented Jul 13, 2017

Correct me if I'm wrong, but this doesn't seem to actually apply to 5.6

@kobelb
Copy link
Contributor Author

kobelb commented Jul 14, 2017

@spalger you're right, no need to backport to 5.x.

@jimgoodwin jimgoodwin added release_note:enhancement Feature:Visualizations Generic visualization features (in case no more specific feature label is available) labels Jul 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Visualizations Generic visualization features (in case no more specific feature label is available) release_note:enhancement review v6.0.0-rc1 v6.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants