Add execution context support for management plugins #128415

alisonelizabeth · 2022-03-23T19:11:21Z

This PR adds execution context support to the platform deployment management apps.

Ingest Pipelines
Index Management (Indices, Component Template, Index Template, Data Streams tabs)
Snapshot & Restore (Snapshots, Repositories, Policies, Restore tabs)
ILM
CCR
Remote clusters
License Management
Rollups
Watcher
~~Dev Tools (Search Profiler, Console, Painless Lab, Grokdebugger)~~ Implemented via APM execution context - app, page, entitiy id #124996
~~Upgrade Assistant~~ Not applicable, as UA is only enabled in 7.17 and this feature is available in 8.2+

Note: I only added this at the top-level app render, with the exception of Index Management and Snapshot + Restore which has it per tab. If we want, we can be more granular and register each route. I propose the current approach, and modify as needed once we start to analyze the data.

How to test

Follow the "How to test this PR?" instructions in #124996 (comment).

Navigate to the list of apps above and verify the events have the correct labels.

…ent_execution_context

elasticmachine · 2022-03-28T22:48:16Z

Pinging @elastic/platform-deployment-management (Team:Deployment Management)

pgayvallet · 2022-03-29T08:52:07Z

src/core/public/mocks.ts

 import { executionContextServiceMock } from './execution_context/execution_context_service.mock';
+export { executionContextServiceMock } from './execution_context/execution_context_service.mock';


Outside of the scope of the PR, but would you mind moving the import statement with the others a few lines up 🙏 ?

sabarasaba

Thanks for working on this @alisonelizabeth, that's a lot of files! Changes lgtm, left a just one suggestion for a snapshot and restore label that looks a bit funny, but no blockers

sabarasaba · 2022-03-29T14:44:57Z

x-pack/plugins/license_management/public/application/app.js

 import { EuiPageContent, EuiPageBody, EuiEmptyPrompt } from '@elastic/eui';

-export class App extends Component {


sabarasaba · 2022-03-29T14:48:24Z

x-pack/plugins/snapshot_restore/public/application/sections/home/restore_list/restore_list.tsx


  // Track component loaded
  useEffect(() => {
    uiMetricService.trackUiMetric(UIM_RESTORE_LIST_LOAD);
  }, [uiMetricService]);

+  useExecutionContext(core.executionContext, {
+    type: 'application',
+    page: 'snapshotRestoreRestores',


this one reads a bit funny, what do you think about snapshotRestoreList or snapshotRestoreRestoreList 🤔

What do you think about snapshotRestoreRestoreTab? I think I originally had snapshotRestoreRestoreList, but changed it since it actually covers any requests within the tab (not just the list view).

Yeah I think snapshotRestoreRestoreTab sounds a lot better!

…ent_execution_context

kibana-ci · 2022-03-30T17:23:04Z

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`crossClusterReplication`	163.1KB	163.3KB	+227.0B
`indexLifecycleManagement`	148.2KB	148.4KB	+155.0B
`indexManagement`	514.8KB	515.5KB	+759.0B
`ingestPipelines`	451.4KB	451.6KB	+116.0B
`licenseManagement`	61.1KB	61.2KB	+67.0B
`remoteClusters`	83.3KB	83.5KB	+182.0B
`rollup`	128.9KB	129.1KB	+174.0B
`snapshotRestore`	258.3KB	258.8KB	+488.0B
`watcher`	272.5KB	272.6KB	+86.0B
total			+2.2KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`crossClusterReplication`	11.9KB	11.9KB	+38.0B
`indexLifecycleManagement`	27.0KB	27.1KB	+21.0B
`ingestPipelines`	13.4KB	13.5KB	+54.0B
`remoteClusters`	7.8KB	7.8KB	+38.0B
`snapshotRestore`	26.6KB	26.7KB	+54.0B
`watcher`	13.6KB	13.6KB	+38.0B
total			+243.0B

Unknown metric groups

ESLint disabled in files

id	before	after	diff
`indexManagement`	5	4	-1

Total ESLint disabled count

id	before	after	diff
`indexManagement`	20	19	-1

History

💚 Build #34596 succeeded ddf4412
💚 Build #34426 succeeded 0b7ee9c
💚 Build #34246 succeeded 8d909c6
💔 Build #34198 failed 5226a32
💚 Build #34048 succeeded a89c2c2
💚 Build #33693 succeeded ec39f94

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

lizozom

This is excellent - Thank you!
Once merged, all date in APM and Fullstory should be labeled with these page names - I'm sure this will really help understanding the workflows!

kibanamachine · 2022-04-04T12:46:20Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 128415 or prevent reminders by adding the backport:skip label.

add execution context support to: SR, ILM, IM, IP

a8acfb8

alisonelizabeth added chore Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes v8.2.0 labels Mar 23, 2022

alisonelizabeth added 4 commits March 24, 2022 09:54

add execution context support to: license management, watcher

674ae7d

add execution context support to: CCR, remote clusters, rollups

22fa7a2

update tests

60019d8

Merge branch 'main' of https://github.com/elastic/kibana into managem…

ec39f94

…ent_execution_context

alisonelizabeth added v8.3.0 and removed v8.2.0 labels Mar 28, 2022

alisonelizabeth added 4 commits March 28, 2022 09:00

Merge branch 'main' of https://github.com/elastic/kibana into managem…

f5b9b27

…ent_execution_context

fix rollup page name

a89c2c2

add execution per tab in SR + IM

5226a32

fix tests

8d909c6

alisonelizabeth marked this pull request as ready for review March 28, 2022 22:48

alisonelizabeth requested review from a team as code owners March 28, 2022 22:48

alisonelizabeth requested review from lizozom and sabarasaba March 28, 2022 22:48

pgayvallet approved these changes Mar 29, 2022

View reviewed changes

address review feedback

0b7ee9c

sabarasaba approved these changes Mar 29, 2022

View reviewed changes

alisonelizabeth added 2 commits March 29, 2022 13:16

address review feedback

ddf4412

Merge branch 'main' of https://github.com/elastic/kibana into managem…

8f849a6

…ent_execution_context

lizozom approved these changes Mar 31, 2022

View reviewed changes

alisonelizabeth merged commit b00ca41 into elastic:main Mar 31, 2022

alisonelizabeth deleted the management_execution_context branch March 31, 2022 12:40

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 4, 2022

kibanamachine added backport:skip This commit does not require backporting and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Apr 4, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add execution context support for management plugins #128415

Add execution context support for management plugins #128415

alisonelizabeth commented Mar 23, 2022 •

edited

Loading

elasticmachine commented Mar 28, 2022

pgayvallet Mar 29, 2022

alisonelizabeth Mar 29, 2022

sabarasaba left a comment

sabarasaba Mar 29, 2022

sabarasaba Mar 29, 2022

alisonelizabeth Mar 29, 2022 •

edited

Loading

sabarasaba Mar 30, 2022

kibana-ci commented Mar 30, 2022

ESLint disabled in files

Total ESLint disabled count

lizozom left a comment •

edited

Loading

kibanamachine commented Apr 4, 2022

		import { executionContextServiceMock } from './execution_context/execution_context_service.mock';
		export { executionContextServiceMock } from './execution_context/execution_context_service.mock';

		import { EuiPageContent, EuiPageBody, EuiEmptyPrompt } from '@elastic/eui';

		export class App extends Component {

Add execution context support for management plugins #128415

Add execution context support for management plugins #128415

Conversation

alisonelizabeth commented Mar 23, 2022 • edited Loading

How to test

elasticmachine commented Mar 28, 2022

pgayvallet Mar 29, 2022

Choose a reason for hiding this comment

alisonelizabeth Mar 29, 2022

Choose a reason for hiding this comment

sabarasaba left a comment

Choose a reason for hiding this comment

sabarasaba Mar 29, 2022

Choose a reason for hiding this comment

sabarasaba Mar 29, 2022

Choose a reason for hiding this comment

alisonelizabeth Mar 29, 2022 • edited Loading

Choose a reason for hiding this comment

sabarasaba Mar 30, 2022

Choose a reason for hiding this comment

kibana-ci commented Mar 30, 2022

💚 Build Succeeded

Metrics [docs]

Async chunks

Page load bundle

ESLint disabled in files

Total ESLint disabled count

History

lizozom left a comment • edited Loading

Choose a reason for hiding this comment

kibanamachine commented Apr 4, 2022

alisonelizabeth commented Mar 23, 2022 •

edited

Loading

alisonelizabeth Mar 29, 2022 •

edited

Loading

lizozom left a comment •

edited

Loading