[Security Solution][Alerts] Remove dead legacy signals code #128328
Conversation
marshallmain
force-pushed
the
remove-dead-code
branch
from
fe76256 to
25f07aa
Compare
marshallmain
added
backport:skip
|
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
marshallmain
added
the
release_note:skip
| @@ -134,4 +138,342 @@ describe('buildAlert', () => { | |||
| expect(groupId).toEqual(groupIds[0]); | |||
| } | |||
| }); | |||
|
|
|||
| describe('recursive intersection between objects', () => { | |||
There was a problem hiding this comment.
These tests got lost in the migration - adding them back since "recursively merging objects" is a bit tricky.
| @@ -118,3 +117,54 @@ export const buildAlertRoot = ( | |||
| [ALERT_GROUP_ID]: generateAlertId(doc), | |||
| }; | |||
| }; | |||
|
|
|||
| export const objectArrayIntersection = (objects: object[]) => { | |||
There was a problem hiding this comment.
These functions are only being moved from build_bulk_body.ts.
|
@marshallmain Tried to run this and the alerts table looks broken to me |
|
@madirey I've seen that in testing before on It should let you add columns still and display them correctly. |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
| isSavedQueryParams(params) || | ||
| isThreatParams(params) | ||
| ) { | ||
| if (!isMachineLearningParams(params)) { |
There was a problem hiding this comment.
Thanks for doing this, @marshallmain. Code looks good, performed sanity test.
Summary
Removes code that was used to generate legacy signals and is no longer used. Updates some unit tests that incorrectly relied on the legacy functions and adds appropriate mocks for PersistenceAlertServices.