Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ally geo smoke test #127982

Merged
merged 12 commits into from
Mar 22, 2022
Merged

ally geo smoke test #127982

merged 12 commits into from
Mar 22, 2022

Conversation

rashmivkulkarni
Copy link
Contributor

Resolves #127799 ( provides a smoke a11y test)
Meta Ref: #51456
Maps accessibility detailed issue: #57271

@rashmivkulkarni rashmivkulkarni added Project:Accessibility [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v8.2.0 v8.1.1 labels Mar 17, 2022
@rashmivkulkarni rashmivkulkarni self-assigned this Mar 17, 2022
@rashmivkulkarni
Copy link
Contributor Author

https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/287

@rashmivkulkarni
Copy link
Contributor Author

@elasticmachine merge upstream

@rashmivkulkarni rashmivkulkarni marked this pull request as ready for review March 18, 2022 15:14
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-accessibility (Project:Accessibility)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

bhavyarm
bhavyarm requested changes Mar 18, 2022
View reviewed changes
x-pack/test/accessibility/apps/maps.ts Outdated Show resolved Hide resolved
x-pack/test/accessibility/apps/maps.ts Show resolved Hide resolved
@rashmivkulkarni
Copy link
Contributor Author

https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/292

@rashmivkulkarni
Copy link
Contributor Author

@elasticmachine merge upstream

nreese
nreese approved these changes Mar 21, 2022
View reviewed changes
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for adding accessibility tests.
code review

@rashmivkulkarni
Copy link
Contributor Author

@elasticmachine merge upstream

@rashmivkulkarni rashmivkulkarni enabled auto-merge (squash) March 22, 2022 19:05
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @rashmivkulkarni

bhavyarm
bhavyarm approved these changes Mar 22, 2022
View reviewed changes
Copy link
Contributor

@bhavyarm bhavyarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Ran, requested changes and Rashmi made those.

@rashmivkulkarni rashmivkulkarni merged commit 72399c4 into elastic:main Mar 22, 2022
kibanamachine pushed a commit that referenced this pull request Mar 22, 2022
@rashmivkulkarni
ally geo smoke test (#127982)
6a67f22 
* ally geo

* remove unwanted data

* addressed review comments

* added maps listing page tests

Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit 72399c4)
@kibanamachine kibanamachine mentioned this pull request Mar 22, 2022
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.1

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Mar 22, 2022
@kibanamachine @rashmivkulkarni
ally geo smoke test (#127982) (#128317)
7499c94 
* ally geo

* remove unwanted data

* addressed review comments

* added maps listing page tests

Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit 72399c4)

Co-authored-by: Rashmi Kulkarni <[email protected]>
@bhavyarm bhavyarm mentioned this pull request Aug 22, 2022
Open
77 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhavyarm bhavyarm bhavyarm approved these changes

@LeeDr LeeDr Awaiting requested review from LeeDr

@nreese nreese Awaiting requested review from nreese

Assignees

@rashmivkulkarni rashmivkulkarni

Labels
auto-backport Deprecated - use backport:version if exact versions are needed [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation Project:Accessibility release_note:skip Skip the PR/issue when compiling release notes v8.1.1 v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(Accessibility) Maps app
6 participants
@rashmivkulkarni @elasticmachine @kibana-ci @kibanamachine @nreese @bhavyarm