[elasticsearch] patch mappings that are missing types

[spalger]

Because this pr is targetting compatibility with 5.6 I started in 5.x and will forward port it to 6.0

With the transition to using the SavedObjectClient for everything and maintaining compatibility with two index formats the front-end code that creates mapping types was brought into focus. Rather than port it to use the SavedObjectClient, or continuing to use some sort of proxy, this change adds a step to the health check that determines if the kibana index has all of the types defined by the 'mappings' uiExport type.

We will remove the type management from the front-end in another pr.

[tylersmalley]

Should be @property

[tylersmalley]

Switching between v5 and v6 partial mappings types:

DELETE .kibana
PUT .kibana
{
  "settings": {
    "number_of_shards": 1
  },
  "mappings": {
     "_default_": {
      "dynamic": "strict"
    },
    "config": {
      "dynamic": true,
      "properties": {
        "buildNum": {
          "type": "keyword"
        }
      }
    }
  }
}

DELETE .kibana
PUT .kibana
{
  "settings": {
    "number_of_shards": 1
  },
  "mappings": {
    "_default_": {
      "dynamic": "strict"
    },
    "doc": {
      "properties": {
        "type": {
          "type": "text",
          "fields": {
            "keyword": {
              "type": "keyword",
              "ignore_above": 256
            }
          }
        },
        "config": {
          "properties": {
            "buildNum": {
              "type": "long"
            }
          }
        }
      }
    }
  }
}

server    log   [00:46:31.756] [info][status][plugin:[email protected]] Status changed from green to yellow - No existing Kibana index found
server    log   [00:46:31.757] [info][status][ui settings] Status changed from green to yellow - Elasticsearch plugin is yellow
server    log   [00:46:31.787] [info][elasticsearch] Adding mappings to kibana index for SavedObject type "index-pattern"
server    log   [00:46:31.796] [info][elasticsearch] Adding mappings to kibana index for SavedObject type "visualization"
server    log   [00:46:31.805] [info][elasticsearch] Adding mappings to kibana index for SavedObject type "search"
server    log   [00:46:31.825] [info][elasticsearch] Adding mappings to kibana index for SavedObject type "dashboard"
server    log   [00:46:31.843] [info][elasticsearch] Adding mappings to kibana index for SavedObject type "url"
server    log   [00:46:31.858] [info][elasticsearch] Adding mappings to kibana index for SavedObject type "server"
server    log   [00:46:31.870] [info][elasticsearch] Adding mappings to kibana index for SavedObject type "timelion-sheet"
server    log   [00:46:32.786] [info][status][plugin:[email protected]] Status changed from yellow to green - Kibana index ready
server    log   [00:46:32.789] [info][status][ui settings] Status changed from yellow to green - Ready
server    log   [00:47:02.850] [info][elasticsearch] Adding mappings to kibana index for SavedObject type "config"
server    log   [00:47:02.858] [info][elasticsearch] Adding mappings to kibana index for SavedObject type "index-pattern"
server    log   [00:47:02.865] [info][elasticsearch] Adding mappings to kibana index for SavedObject type "visualization"
server    log   [00:47:02.877] [info][elasticsearch] Adding mappings to kibana index for SavedObject type "search"
server    log   [00:47:02.885] [info][elasticsearch] Adding mappings to kibana index for SavedObject type "dashboard"
server    log   [00:47:02.897] [info][elasticsearch] Adding mappings to kibana index for SavedObject type "url"
server    log   [00:47:02.906] [info][elasticsearch] Adding mappings to kibana index for SavedObject type "server"
server    log   [00:47:03.032] [info][elasticsearch] Adding mappings to kibana index for SavedObject type "timelion-sheet"

[tylersmalley]

Jenkins, test it

[tylersmalley]

The failure might be legit - re-running as it was a timeout.

https://kibana-ci.elastic.co/job/elastic+kibana+pull-request+multijob-selenium/5950/console

[tylersmalley]

Here is the issue:

log   [01:11:38.399] [info][elasticsearch] Adding mappings to kibana index for SavedObject type "visualization"
log   [01:11:38.425] [error][status][plugin:[email protected]] Status changed from green to red - [illegal_argument_exception] mapper [version] cannot be changed from type [long] to [integer]

[tylersmalley]

Any ideas as to how it's becoming a long?

[epixa]

This is mostly a guess, but I think this issue with long -> integer is the result of our tests seeding the .kibana index before Kibana has been started up, so mappings haven't yet been created. Elasticsearch sees a numeric field and assumes long, and then it errors later when Kibana starts up and tries to set integer as the field type.

[spalger]

jenkins, test this

[epixa]

LGTM