-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[shared-ux] Migrate add from library button to shared ux directory #127605
Conversation
💔 Build FailedFailed CI StepsMetrics [docs]Public APIs missing comments
History
To update your PR or re-run it, just comment with: |
TBH, I don't really understand the utility of this button as a "Shared" component. It's simply an instance of the already existing shared component For example, considering that this new This may be discussion that needs to happen with the greater team around conversion strategy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments, mostly nits and some cleanup
packages/kbn-shared-ux-components/src/toolbar/buttons/add_from_library/add_from_library.mdx
Outdated
Show resolved
Hide resolved
packages/kbn-shared-ux-components/src/toolbar/buttons/add_from_library/add_from_library.mdx
Outdated
Show resolved
Hide resolved
...s/kbn-shared-ux-components/src/toolbar/buttons/add_from_library/add_from_library.stories.tsx
Outdated
Show resolved
Hide resolved
...ages/kbn-shared-ux-components/src/toolbar/buttons/add_from_library/add_from_library.test.tsx
Outdated
Show resolved
Hide resolved
...ages/kbn-shared-ux-components/src/toolbar/buttons/add_from_library/add_from_library.test.tsx
Outdated
Show resolved
Hide resolved
packages/kbn-shared-ux-components/src/toolbar/buttons/add_from_library/add_from_library.tsx
Outdated
Show resolved
Hide resolved
💚 Build SucceededMetrics [docs]Module Count
Public APIs missing comments
Async chunks
Unknown metric groupsAPI count
async chunk count
History
To update your PR or re-run it, just comment with: cc @rshen91 |
Summary
This PR migrates the add from library button from the
presentation_utils
directory toshared_ux
. The primary button has already been migrated in #125998.Checklist
Delete any items that are not applicable to this PR.
For maintainers