Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Fix type check failure #127277

Merged
merged 1 commit into from
Mar 9, 2022
Merged

[Lens] Fix type check failure #127277

merged 1 commit into from
Mar 9, 2022

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Mar 9, 2022 •
edited
Loading

Summary

By merging #126903 and #126885 and this, we broke types checks in main.

This PR is fixing this.

@stratoula stratoula marked this pull request as ready for review March 9, 2022 13:44
@stratoula stratoula requested a review from a team as a code owner March 9, 2022 13:44
mistic
mistic approved these changes Mar 9, 2022
View reviewed changes
Copy link
Member

@mistic mistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mistic mistic added Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.2.0 labels Mar 9, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@mistic mistic added backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes labels Mar 9, 2022
dej611
dej611 approved these changes Mar 9, 2022
View reviewed changes
Copy link
Contributor

@dej611 dej611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review only 👍

@jbudz jbudz merged commit 46a739e into elastic:main Mar 9, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled in files

id before after diff
apm 14 15 +1
securitySolution 66 67 +1
uptime 6 7 +1
total +3

ESLint disabled line counts

id before after diff
apm 82 85 +3
uptime 42 48 +6
total +9

References to deprecated APIs

id before after diff
canvas 64 70 +6
fleet 4 5 +1
lens 185 237 +52
monitoring 28 40 +12
stackAlerts 157 183 +26
upgradeAssistant 3 8 +5
total +102

Total ESLint disabled count

id before after diff
apm 96 100 +4
securitySolution 513 514 +1
uptime 48 55 +7
total +12

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mistic mistic mistic approved these changes

@mbondyra mbondyra mbondyra approved these changes

@dej611 dej611 dej611 approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@stratoula @elasticmachine @kibana-ci @dej611 @mbondyra @mistic @jbudz