Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[data views] functional tests to typescript #126977

Merged
merged 6 commits into from
Mar 7, 2022
Merged

[data views] functional tests to typescript #126977

merged 6 commits into from
Mar 7, 2022

Conversation

mattkime
Copy link
Contributor

@mattkime mattkime commented Mar 5, 2022 •
edited
Loading

Summary

Converting data view functional tests to typescript.

@mattkime mattkime changed the title first five files [data views] functional tests to typescript Mar 5, 2022
@mattkime mattkime added backport:skip This commit does not require backporting Feature:Data Views Data Views code and UI - index patterns before 8.0 release_note:skip Skip the PR/issue when compiling release notes v8.2.0 Team:AppServicesSv labels Mar 6, 2022
@mattkime mattkime marked this pull request as ready for review March 6, 2022 02:04
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesSv)

@mattkime mattkime requested a review from a team March 6, 2022 02:04
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Dosant
Dosant approved these changes Mar 7, 2022
View reviewed changes
Copy link
Contributor

@Dosant Dosant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mattkime mattkime merged commit 8b82657 into elastic:main Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dosant Dosant Dosant approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Data Views Data Views code and UI - index patterns before 8.0 release_note:skip Skip the PR/issue when compiling release notes v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mattkime @elasticmachine @kibana-ci @Dosant